Use fixed-width reads for Btrieve file fields#1
Open
GregoryMorse wants to merge 6 commits into
Open
Conversation
Author
|
Just to note - this has been tested independently now on Windows, Linux, MacOS by just statically compiling against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes LP64 portability issues when reading Btrieve on-disk fields.
The current code uses
long/unsigned longand pointer casts for several serialized 32-bit fields. That works on Win32/Win64 becauselongis 32-bit there, but on Linux/macOSlongis 64-bit, so packed structures and direct casts can read the wrong bytes.Changes:
<stdint.h>fixed-width types for serialized page IDs and constants.Validation:
BtrieveFileSaver.vcxprojwith VS2022,Release|Win32.