Skip to content

fix(auth): grant only Administrators on first-user promotion - #1165

Merged
ericfitz merged 1 commit into
mainfrom
fix/1156-first-user-not-reviewer
Nov 13, 2026
Merged

ericfitz merged 1 commit into
mainfrom
fix/1156-first-user-not-reviewer

Conversation

@ericfitz

Copy link
Copy Markdown
Owner

First-user auto-promotion now adds the first user to the Administrators group only, not Security Reviewers. Human decision recorded in docs/superpowers/specs/2026-11-12-adr-first-user-promotion-admin-only.md. The integration harness's admin is framework.AdminUserID ("charlie"); surveys are submitted by alice.

Fixes #1156

🤖 Generated with Claude Code

https://claude.ai/code/session_011fnCFtfDUEvZWeBTm7KCAP

First-user auto-promotion now adds the user to Administrators only; the
Security Reviewers grant is removed (ADR 2026-11-12). Reviewer membership
comes only from everyone_is_a_reviewer or an explicit grant.

Integration harness: the admin identity switches from test-admin to
charlie (project convention); the idempotent DB promotion stays as a
fallback. The survey response workflow test now has charlie administer
the survey and alice (non-reviewer) submit it. admin_promotion_test
asserts the first user is not a Security Reviewer. TestTimmyRuntimeToggle,
which previously skipped because charlie was not admin, skips when
timmy.enabled is config-controlled (409).

Fixes #1156

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011fnCFtPzfvJmmkCSfXZgqP
@ericfitz
ericfitz merged commit ed0952a into main Nov 13, 2026
18 checks passed
@ericfitz
ericfitz deleted the fix/1156-first-user-not-reviewer branch November 13, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: survey response workflow test fails on a fresh DB (first-user promotion makes test-admin a security reviewer)

1 participant