Repository navigation
fix(auth): grant only Administrators on first-user promotion - #1165
Merged
Merged
Conversation
First-user auto-promotion now adds the user to Administrators only; the Security Reviewers grant is removed (ADR 2026-11-12). Reviewer membership comes only from everyone_is_a_reviewer or an explicit grant. Integration harness: the admin identity switches from test-admin to charlie (project convention); the idempotent DB promotion stays as a fallback. The survey response workflow test now has charlie administer the survey and alice (non-reviewer) submit it. admin_promotion_test asserts the first user is not a Security Reviewer. TestTimmyRuntimeToggle, which previously skipped because charlie was not admin, skips when timmy.enabled is config-controlled (409). Fixes #1156 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fnCFtPzfvJmmkCSfXZgqP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-user auto-promotion now adds the first user to the Administrators group only, not Security Reviewers. Human decision recorded in
docs/superpowers/specs/2026-11-12-adr-first-user-promotion-admin-only.md. The integration harness's admin isframework.AdminUserID("charlie"); surveys are submitted by alice.make verifypassed; combined integration run with fix: PUT /admin/settings/{key} returns 409 for settings not explicitly set by config or env #1160 (now on main): 101 passed, 0 failed, 8 skipped (TestTimmyRuntimeTogglePASS). The rebased tree differs from the tested tree only by fix: PUT /admin/settings/{key} returns 409 for settings not explicitly set by config or env #1160's ADR file.Fixes #1156
🤖 Generated with Claude Code
https://claude.ai/code/session_011fnCFtfDUEvZWeBTm7KCAP