Skip to content

Minor cleanup#30

Merged
ericfell merged 1 commit into
masterfrom
cleanup
Sep 8, 2025
Merged

Minor cleanup#30
ericfell merged 1 commit into
masterfrom
cleanup

Conversation

@jeremyfell

@jeremyfell jeremyfell commented Sep 7, 2025

Copy link
Copy Markdown
Collaborator
  • Fixes some typos and capitalization
  • one electron -> one-electron
  • Changes pyproject version
  • Fixes voltage_to_fit as return value name, should be voltage

@jeremyfell jeremyfell requested a review from ericfell September 7, 2025 05:08
@codecov-commenter

codecov-commenter commented Sep 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (82d012b) to head (6e1af99).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          397       397           
=========================================
  Hits           397       397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericfell ericfell left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/cvsim/fit_curve.py

Returns
-------
voltage_to_fit : np.ndarray

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these were named properly already, see the _fit( function that returns this

@ericfell ericfell merged commit ad5e183 into master Sep 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants