Skip to content

fix: adapt integration tests to SDK 4.34.0 API changes - #78

Closed
tutkat wants to merge 1 commit into
mainfrom
fix/tests-sdk-4.34
Closed

tutkat wants to merge 1 commit into
mainfrom
fix/tests-sdk-4.34

Conversation

@tutkat

@tutkat tutkat commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tutkat
tutkat requested a review from a team as a code owner October 26, 2026 18:00
@tutkat

tutkat commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Zamykam - commit z poprawkami testów (828d21a) został przeniesiony do #79, które dodatkowo regeneruje SDK o ASNs i kompiluje testy z nowym SDK.

@tutkat tutkat closed this Oct 30, 2026
tutkat added a commit that referenced this pull request Nov 2, 2026
This API Sync PR was created manually on 2026-10-30, because the `Sync
fabricv4 API spec` workflow run of the same day ([run
41040383265](https://github.com/equinix/equinix-sdk-java/actions/runs/41040383265))
fetched a changed spec but skipped patch / generate / PR steps.

**Why the workflow skipped it:** every step after `Fetch latest spec` is
guarded by `cur_version != new_version`, and Equinix changed the spec
**without bumping `info.version`** (still `4.34.0`).

This PR updates the SDK to the spec published on 2026-10-30 (version
`4.34.0`, unchanged):

* Latest API Spec is fetched - version 4.34.0 (content differs from the
2026-10-26 sync)
* Patches have been applied (two spec patches rebased, see below)
* Generated client has been updated

# Changes in SDK

## New APIs

* **AsnsApi** – Autonomous System Number management (Beta): `createAsn`,
`searchAsns`, `getAsnById`, `patchAsnById`, `deleteAsnById` (`POST
/asns`, `POST /asns/search`, `GET|PATCH|DELETE /asns/{asnId}`)

The live spec now has 274 operations; the SDK covers all of them
(verified by `operationId`).

## New Models (21)

### ASNs (13 models)
`Asn`, `AsnAsset`, `AsnAssetIpBlockRef`, `AsnAssetService`, `AsnChange`,
`AsnPatchOperation`, `AsnRange`, `AsnRirRegion`, `AsnSearchRequestBody`,
`AsnSearchResponseBody`, `AsnSearchSortCriteria`, `AsnState`,
`CreateAsnRequest`

### Inline-schema extractions (renamed list item / nested types)
`CompanyProfileContactContactsInner`,
`CrossConnectResponseAllowedActionsInner`, `ErrorAdditionalInfoInner`,
`HopProbesInner`, `MetricDatapointsInner`,
`ValidateRequestFilterAndInner`,
`InternetAccessRoutingProtocolBgpAllOfAsn`,
`InternetAccessRoutingProtocolBgpRequestAllOfAsn`

## Removed Models (41)

Dropped from the spec (the live spec has ~90 fewer schemas than the
2026-10-26 one):

* **Replaced by `*Inner` / `*AllOf*` types:**
`CompanyProfileContactContacts`, `CrossConnectResponseAllowedActions`,
`HopProbes`, `MetricDatapoints`, `PriceErrorAdditionalInfo`,
`ValidateRequestFilterAnd`, `InternetAccessRoutingProtocolBgpAsn`,
`InternetAccessRoutingProtocolBgpRequestAsn`
* **Replaced by an existing model:**
`CrossConnectASideRequestDemarcationPoint` →
`CrossConnectDemarcationPoint`
* **Removed with no replacement:** `CompanyProfileResponseAccount`,
`ConnectionInvitation`, `ConnectionState`, `CrossConnectEndCustomer`,
`CrossConnectProject`, `CrossConnectProvider`, `DeleteCrossConnect`,
`EndCustomer`, `GatewayIpv4`, `GatewayPackageCode`,
`GatewaySearchRequest`, `GatewaySortCriteria`, `GatewaySortDirection`,
`GatewayTunnelSearchRequest`, `GatewayTunnelSortCriteria`,
`GatewayTunnelSortDirection`, `InternetAccess`, `PhysicalPortSettings`,
`PrecisionTimePrice`, `ResponseIncompleteDetails`,
`ResponseUsageInputTokensDetails`, `ResponseUsageOutputTokensDetails`,
`RouteAggregationState`, `RouteFilterState`, `Router`,
`ServiceProfileLastMileContactInfoItem`, `SignatureRequest`,
`SignatureType`, `StreamAssetInterface`, `TunnelRoutingProtocolIpv4`,
`TunnelRoutingProtocolPostRequestIpv4`, `VpicInterface`

## Updated Models

### Removed fields (breaking)

| Model | Removed field |
|---|---|
| `Connection` | `state` |
| `ConnectionPostRequest` | `endCustomer` |
| `Port` | `endCustomer` |
| `PortRequest` | `settings` |
| `PhysicalPort` | `interface`, `settings` |
| `CompanyProfileResponse` | `account` |
| `PrecisionTimeServiceResponse` | `pricing` |
| `RouteAggregationsData` | `state` |
| `RouteFiltersData` | `state` |

### Changed field types (breaking - source incompatible)

* `CompanyProfileContact.contacts`:
`List<CompanyProfileContactContacts>` →
`List<CompanyProfileContactContactsInner>`
* `CrossConnectASideRequest.demarcationPoint`:
`CrossConnectASideRequestDemarcationPoint` →
`CrossConnectDemarcationPoint`
* `Error.additionalInfo`, `MetroError.additionalInfo`,
`PriceError.additionalInfo`: `List<PriceErrorAdditionalInfo>` →
`List<ErrorAdditionalInfoInner>`
* `Hop.probes`: `List<HopProbes>` → `List<HopProbesInner>`
* `Metric.datapoints`: `List<MetricDatapoints>` →
`List<MetricDatapointsInner>`
* `ValidateRequestFilter.and`: `List<ValidateRequestFilterAnd>` →
`List<ValidateRequestFilterAndInner>`
* `InternetAccessRoutingProtocolBgp.asn` /
`InternetAccessRoutingProtocolBgpRequest.asn`: `…BgpAsn` /
`…BgpRequestAsn` → `…BgpAllOfAsn` / `…BgpRequestAllOfAsn`

### Relaxed requiredness (not breaking)

`value` is now `@Nullable` instead of `@Nonnull` in the JSON-patch style
change models: `AppDomainChangeOperation`,
`AppLinkAppServiceAttachmentChangeOperation`, `AppLinkChangeOperation`,
`AppProcessorChangeOperation`, `AppServiceChangeOperation`,
`AppSubscriptionChangeOperation`, `CloudRouterChangeOperation`,
`CompanyProfileChangeItem`, `ConnectionChangeOperation`,
`NetworkChangeOperation`, `PortChangeOperation`,
`PrecisionTimeChangeOperation`, `ServiceTokenChangeOperation`,
`RouteAggregationRulesPatchRequestItem`,
`RouteAggregationsPatchRequestItem`, `RouteFilterRulesPatchRequestItem`,
`RouteFiltersPatchRequestItem`.

## Breaking Changes

* 41 models removed (see above) and 9 models lost fields - notably
`Connection.state`, `Port.endCustomer`,
`ConnectionPostRequest.endCustomer`, `RouteFiltersData.state`,
`RouteAggregationsData.state`
* Several list / nested field types were renamed to `*Inner` / `*AllOf*`
classes
* No API class or operation was removed or changed signature

> ⚠️ **Please review before merging.** Removing `Connection.state` /
`Port.endCustomer` from the published spec looks like it could be a
documentation-side regression rather than an intentional API change (not
verified against the live API). Worth confirming with the API owners
before releasing.

## Spec patch changes

Both spec patches under `spec/services/fabricv4/patches/` no longer
applied (Equinix reordered the `required` lists), so `make patch`
failed. They were regenerated against the new layout with the same
effect:

* `20240909-connection_action-required-field-skip.patch` -
`ConnectionAction.href` not required
* `20260624-internet_access_service-order-required-skip.patch` -
`InternetAccessService.order` not required

## Known follow-up

* Integration tests (`equinix-openapi-fabric-tests`): the fixes from #78
(commit cherry-picked, #78 closed in favour of this PR) are included;
the test module compiles against the regenerated SDK. Tests were not
executed (need UAT credentials). ASNs tests still to be added.
* The sync workflow should compare spec content, not only
`info.version`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant