Windows support - #51
Merged
Merged
Conversation
Separated out from the devel branch.
tynanford
reviewed
Jul 31, 2026
tynanford
reviewed
Jul 31, 2026
Collaborator
|
Thanks @pheest ! I don't have a windows setup here to test right now. The linux IOC we have still runs as before so that is good. In general the changes look good to me. Tagging a few others in case they use windows @kangarooMouse @phbran @eddybl
Yes that is good. I think at the time, we decided to advertise >=3.6 but kept the code compatible with lower versions. We are now long past the time when that makes sense. |
Removed the calcout type from _dbdapi.dbd
Reverted use of get_pyhon_version to use of get_config_var('VERSION').
Added use of <direct.h> to setup.c to resolve a compiler warning.
tynanford
reviewed
Aug 7, 2026
tynanford
approved these changes
Aug 7, 2026
tynanford
left a comment
tynanford
left a comment
Collaborator
There was a problem hiding this comment.
Besides the small f string issue this looks ready to merge to me
This was referenced Aug 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dbdset.c, <sharelib.h> needs to be included in order to enable the use of epicsShareExtern for the linker to access pvar_rset_aSubRSET.
I rules_py, use of 'install -m 644' is not suitable for Windows use.
I have replaced this with use of equivalent EPICS compatability macros.
In config_py, the file extension of the _dbapi module file needs to be '.pyd' (not .dll') or Python won't load it.
(Please do not ask me why, when Python on Linux loads a '.so' file just fine.)
In ci-scripts-build.yaml, I have added testing for Windows.
Note the issue described by epics-base/ci-scripts#112 which has been addressed recently.
Thank you @ralphlange and @anderslindho for making this possible.
I have added 'bash' as the shell for the 'more setup python' command which otherwise uses Linux syntax.
In makehelper.py, Python sysconfig has been available since Python3.2.
We say that we support the module from 3.6.
So ... why do we still need to use distutils at all?
Python on Windows did not have the 'LIBDIR' variable until 3.13.
The 'libs' subfolder of the Python install is however always where library files are located, so that can be used.
'BASECFLAGS' is not a define on Windows.