Order dependent bug - #46673
Draft
Wenwei-Zhao wants to merge 1 commit into
Draft
Conversation
… file separation Signed-off-by: Wenwei Zhao <wenweizhao@google.com>
Wenwei-Zhao
force-pushed
the
order_dependent_bug
branch
from
August 12, 2026 22:34
3db3654 to
db5edb3
Compare
Contributor
Author
|
\assign @adisuissa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Fix flaky order-dependent stats_test failures via physical test file separation
Additional Description: The tests
NonNumberValueFormattedandGaugeNonNumberValueFormattedboth trigger identical error logs emitted viaENVOY_LOG_PERIODIC_MISCinstats.cc. Because this macro rate-limits logging to prevent log spam, running these tests consecutively in the same target process led to one suppressing the other, causing flaky test failures under randomized execution ordering.Risk Level: low
Testing: NA
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA