Skip to content

Avoid unnecesary renaming of watcher_target.yaml - #46656

Open
etruong42 wants to merge 1 commit into
envoyproxy:mainfrom
etruong42:atomicconfigtest
Open

Avoid unnecesary renaming of watcher_target.yaml#46656
etruong42 wants to merge 1 commit into
envoyproxy:mainfrom
etruong42:atomicconfigtest

Conversation

@etruong42

Copy link
Copy Markdown
Contributor

This avoids the race condition where watcher_target.yaml is not present

Change-Id: I7f8c67023ac31f3a9cac294caca5c0d18c30ee1d

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #46656 was opened by etruong42.

see: more, trace.

@etruong42

Copy link
Copy Markdown
Contributor Author

See

2026-08-11T17:15:35.6905243Z [ RUN      ] IpVersions/IpTaggingIntegrationTest.IptaggingFilterWithReloadNoCrashOnLdsUpdate/1
2026-08-11T17:15:35.6906297Z [2026-08-11 17:15:25.306][74][error][config] [./source/common/config/datasource.h:140] Failed to read file: Invalid path: /mnt/engflow/worker/work/3/exec/_tmp/985f8d2239d6f4f000d289a933343330/ip_tagging_test/watcher_target.yaml
2026-08-11T17:15:35.6907150Z ./test/integration/server.h:483: Failure
2026-08-11T17:15:35.6907664Z Value of: TestUtility::waitForCounter(statStore(), name, value_matcher, time_system_, timeout, dispatcher)
2026-08-11T17:15:35.6908351Z   Actual: false (timed out waiting for http.config_test.ip_tagging.reload_success to is >= 2: current value 1)
2026-08-11T17:15:35.6909104Z Expected: true
2026-08-11T17:15:35.6909288Z Stack trace:
2026-08-11T17:15:35.6909560Z   0xaaaaebcf3ce8: Envoy::IntegrationTestServer::waitForCounter()
2026-08-11T17:15:35.6910423Z   0xaaaaebabf1b0: Envoy::(anonymous namespace)::IpTaggingIntegrationTest_IptaggingFilterWithReloadNoCrashOnLdsUpdate_Test::TestBody()
2026-08-11T17:15:35.6911165Z   0xaaaaed22be04: testing::internal::HandleExceptionsInMethodIfSupported<>()
2026-08-11T17:15:35.6911560Z   0xaaaaed22bc9c: testing::Test::Run()
2026-08-11T17:15:35.6911830Z   0xaaaaed22cf10: testing::TestInfo::Run()
2026-08-11T17:15:35.6912094Z ... Google Test internal frames ...
2026-08-11T17:15:35.6912260Z 
2026-08-11T17:15:35.6912665Z [external/abseil-cpp/absl/flags/internal/flag.cc : 148] RAW: Restore saved value of envoy_quic_always_support_server_preferred_address to: true
2026-08-11T17:15:35.6913561Z [external/abseil-cpp/absl/flags/internal/flag.cc : 148] RAW: Restore saved value of envoy_reloadable_features_runtime_initialized to: false
2026-08-11T17:15:35.6914453Z [external/abseil-cpp/absl/flags/internal/flag.cc : 148] RAW: Restore saved value of envoy_quic_always_support_server_preferred_address to: true
2026-08-11T17:15:35.6915339Z [external/abseil-cpp/absl/flags/internal/flag.cc : 148] RAW: Restore saved value of envoy_reloadable_features_runtime_initialized to: false
2026-08-11T17:15:35.6916321Z [  FAILED  ] IpVersions/IpTaggingIntegrationTest.IptaggingFilterWithReloadNoCrashOnLdsUpdate/1, where GetParam() = 4-byte object <01-00 00-00> (11072 ms)
2026-08-11T17:15:35.6917107Z [----------] 6 tests from IpVersions/IpTaggingIntegrationTest (11342 ms total)
2026-08-11T17:15:35.6917390Z 
2026-08-11T17:15:35.6917496Z [----------] Global test environment tear-down
2026-08-11T17:15:35.6917804Z [==========] 6 tests from 1 test suite ran. (11343 ms total)
2026-08-11T17:15:35.6918091Z [  PASSED  ] 5 tests.
2026-08-11T17:15:35.6918524Z [  FAILED  ] 1 test, listed below:
2026-08-11T17:15:35.6919173Z [  FAILED  ] IpVersions/IpTaggingIntegrationTest.IptaggingFilterWithReloadNoCrashOnLdsUpdate/1, where GetParam() = 4-byte object <01-00 00-00>
2026-08-11T17:15:35.6919748Z 
2026-08-11T17:15:35.6919822Z  1 FAILED TEST

at https://productionresultssa4.blob.core.windows.net/actions-results/c45bf2e4-7666-46a7-9868-8e86f60424d2/workflow-job-run-d11aecb9-9996-5e57-b68f-a24aaf5bd690/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-08-11T20%3A03%3A46Z&sig=emA%2FlIjAKV6E7Mo%2B837r1MMypvWt6c2SH9FVmoVuGj0%3D&ske=2026-08-11T22%3A10%3A21Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-08-11T18%3A10%3A21Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-08-11T19%3A53%3A41Z&sv=2025-11-05

This avoids the race condition where watcher_target.yaml is not present

Change-Id: I7f8c67023ac31f3a9cac294caca5c0d18c30ee1d
Signed-off-by: Ethan Truong <ethantruong@google.com>
@etruong42

Copy link
Copy Markdown
Contributor Author

/assign phlax

@etruong42
etruong42 marked this pull request as ready for review August 13, 2026 01:59
@etruong42
etruong42 requested a review from nezdolik as a code owner August 13, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants