c-ares: disable shared resolver by default - #46585
Closed
andy-fong wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Andy Fong <andy.fong@solo.io>
Signed-off-by: Andy Fong <andy.fong@solo.io>
Signed-off-by: Andy Fong <andy.fong@solo.io>
Contributor
|
/retest |
Contributor
|
The normal process is committed the change into main then back port to release branch |
Contributor
|
Please create a PR off Envoy main to disable this runtime guard |
Member
|
please open the PR against the main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: c-ares: disable shared resolver by default
Additional Description:
DnsFilter would call createDnsResolver() from a workerthread that would cause a race when sharing dns resolvers.
Turn off this feature until the race is fixed. Relates to #46577 and #45073
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: