Use "current" copyright-end-year in the strict style check#374
Merged
Conversation
Follow-up cleanup to #370, mirroring enthought/envisage#607. ets-copyright-checker (flake8-ets) 1.1.0 now supports --copyright-end-year current, so we can pin the buffered end year in one place and have the strict check use the current year: - Pin the buffered copyright end year in setup.cfg (copyright-end-year = 2026), as the single source of truth for both the merge-blocking style check and local flake8 runs. - Drop the --copyright-end-year override (and the now-unused EXPECTED_COPYRIGHT_END_YEAR constant) from the merge-blocking etstool.py flake8 check; it just runs flake8 now. - Have the strict style check override the pinned value with --copyright-end-year current to report out-of-date copyright end years. Pins flake8-ets >= 1.1.0, since the "current" value is only available from that release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #370, mirroring enthought/envisage#607.
That PR adopted a hard-coded copyright end year to avoid CI breaking on the new-year rollover, but couldn't express "use the current year" for the strict check. ets-copyright-checker (
flake8-ets) 1.1.0 now supports--copyright-end-year current, so we can do the cleanup that PR wanted:setup.cfg(copyright-end-year = 2026), so it's the single source of truth used by both the merge-blocking style check (etstool.py flake8) and localflake8runs.--copyright-end-yearoverride (and the now-unusedEXPECTED_COPYRIGHT_END_YEARconstant) frometstool.py; it just runsflake8now.--copyright-end-year currentto report out-of-date copyright end years.Pins
flake8-ets >= 1.1.0, since thecurrentvalue is only available from that release.🤖 Generated with Claude Code