Skip to content

Add activation sound effect for sequential vase unlock #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuq merged 2 commits into from
Sep 30, 2026
Merged

Add activation sound effect for sequential vase unlock #2975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee61a1
audio: Add activation sound effect for sequential vase unlock
FinalRed Sep 29, 2026
6ea6827
audio vase activation to filling_barrel components & link external re…
FinalRed Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scenes/game_elements/props/filling_barrel/components/Vase_activate.wav
View file
Open in desktop

@manuq manuq Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing sounds are in scenes/game_elements/props/filling_barrel/components/. I suggest you follow the same pattern and move this WAV there.

Git LFS file not shown
24 changes: 24 additions & 0 deletions scenes/game_elements/props/filling_barrel/components/Vase_activate.wav.import
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
[remap]

importer="wav"
type="AudioStreamWAV"
uid="uid://c3cl4rglkh5um"
path="res://.godot/imported/Vase_activate.wav-41d2b392f9b0dd094e96b397ccc5f7fb.sample"

[deps]

source_file="res://scenes/game_elements/props/filling_barrel/components/Vase_activate.wav"
dest_files=["res://.godot/imported/Vase_activate.wav-41d2b392f9b0dd094e96b397ccc5f7fb.sample"]

[params]

force/8_bit=false
force/mono=false
force/max_rate=false
force/max_rate_hz=44100
edit/trim=false
edit/normalize=false
edit/loop_mode=0
edit/loop_begin=0
edit/loop_end=-1
compress/mode=2
3 changes: 3 additions & 0 deletions ...ts/lore_quests/song_sanctuary_3/1_ink_drinker_levels/components/barrel_unlock_sequence.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ extends Node
@export var barrels: Array[FillingBarrel]
@export var auto_start: bool = true
@export var randomize_barrel_order: bool = false
@export var unlock_sound: AudioStreamPlayer

var current_target_index: int = 0

Expand Down Expand Up @@ -37,6 +38,8 @@ func unlock_next_barrel() -> void:
if current_target_index < barrels.size():
var target: FillingBarrel = barrels[current_target_index]
target.is_locked = false
if unlock_sound:
unlock_sound.play()


func _on_barrel_completed() -> void:
Expand Down
8 changes: 7 additions & 1 deletion scenes/quests/lore_quests/song_sanctuary_3/1_ink_drinker_levels/ink_combat_round_6.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
[ext_resource type="Script" uid="uid://en37d2lad0px" path="res://scenes/quests/lore_quests/song_sanctuary_3/1_ink_drinker_levels/components/barrel_unlock_sequence.gd" id="3_ihx08"]
[ext_resource type="TileSet" uid="uid://bjx3gvah0ycl1" path="res://tiles/foam_2.tres" id="5_4co4a"]
[ext_resource type="TileSet" uid="uid://do0ffypatd77h" path="res://tiles/bridges.tres" id="5_bl3l0"]
[ext_resource type="AudioStream" uid="uid://c3cl4rglkh5um" path="res://scenes/game_elements/props/filling_barrel/components/Vase_activate.wav" id="5_n0ti8"]
[ext_resource type="PackedScene" uid="uid://iu2q66clupc6" path="res://scenes/game_elements/characters/player/player.tscn" id="5_pbtyo"]
[ext_resource type="SpriteFrames" uid="uid://dtoylirwywk0j" path="res://scenes/game_elements/characters/components/sprite_frames/storyweaver_blue.tres" id="6_0oabu"]
[ext_resource type="PackedScene" uid="uid://lgu7aeqa7o3r" path="res://scenes/game_elements/props/door/door.tscn" id="7_bl3l0"]
Expand Down Expand Up @@ -69,9 +70,14 @@ script = ExtResource("3_4co4a")
clip = &"cozy"
metadata/_custom_type_script = "uid://c2lx7gvkonxaa"

[node name="BarrelUnlockSequence" type="Node" parent="." unique_id=961449658 node_paths=PackedStringArray("barrels")]
[node name="BarrelUnlockSequence" type="Node" parent="." unique_id=961449658 node_paths=PackedStringArray("barrels", "unlock_sound")]
script = ExtResource("3_ihx08")
barrels = [NodePath("../OnTheGround/FillingBarrel"), NodePath("../OnTheGround/FillingBarrel2"), NodePath("../OnTheGround/FillingBarrel3")]
unlock_sound = NodePath("AudioStreamPlayer2D")

[node name="AudioStreamPlayer2D" type="AudioStreamPlayer" parent="BarrelUnlockSequence" unique_id=1673907098]
stream = ExtResource("5_n0ti8")
bus = &"SFX"

[node name="Cinematic" type="Node2D" parent="." unique_id=590207237]
script = ExtResource("30_t7x86")
Expand Down
Loading