Collectible threads: Integrate more visually enticing animations - #2960
melalicialorenamoyanocastaneda-png wants to merge 31 commits into
Conversation
|
Play this branch at https://play.threadbare.game/branches/melalicialorenamoyanocastaneda-png/main/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This is looking good, thanks @melalicialorenamoyanocastaneda-png . Please check my feedback.
| ItemType.MEMORY: preload("uid://5wscjc8yqqts"), | ||
| ItemType.IMAGINATION: preload("uid://6bf8rum68wq3"), | ||
| ItemType.SPIRIT: preload("uid://cepg1o3ihp055") | ||
| ItemType.MEMORY: preload("uid://xm1p6x8oqteb"), | ||
| ItemType.IMAGINATION: preload("uid://dnjaa4bhfjdvr"), | ||
| ItemType.SPIRIT: preload("uid://chyvv5qjtwgga") |
There was a problem hiding this comment.
The UIDs changed, probably because the assets were moved outside of Godot.
There was a problem hiding this comment.
nono, it's because I wanted to load the new versions that I made before in the other task, but even if I changed the sites of the archives I saw that the images did'nt change because the still had a shadow and I wanted to use the one that did'nt have shadow, then afte a little I saw why, and I saw that in the resource of the thread and in the code it still had the UID of the old ones with shadow, that's why I changed them
There was a problem hiding this comment.
I putted the images back in the carpets in any case but the UIDS still going to be of the new threads because they don't use a incorporated shadow instead the original threads have a shadow incorporated and they have to be saparated for the animation, that's why I say again I putted the UIDS of the new threads and changed the original by the news in the animations, but I putted the carpet as they were originally as you say
There was a problem hiding this comment.
These were moved from assets/first_party/collectibles/world_imagination.png to this "Original_threads" folder, and without maintaining the UIDs. I think they were fine in their original location.
There was a problem hiding this comment.
Even if they were fine there, I had to change them because of the shadow
There was a problem hiding this comment.
If not then I put them in the carpets back but the UID will stay as I said because of the shadow
There was a problem hiding this comment.
I was scared to change the carpets again but I think nothing happened jajajajaja
There was a problem hiding this comment.
emmm no, there is a error but I don't understand it
There was a problem hiding this comment.
alright there is not the error anymore, I fixed it but as I say in the comments up, the uid will still be changed
| ## The highlight frames are white so that they can be tintend to match the | ||
| ## thread, self_modulate is used because modulate is animated by the reveal | ||
| ## and collected animations. |
There was a problem hiding this comment.
Thanks for the explanation of why self_modulate is used!
| for node: CanvasItem in [sprite_2d, shadow, highlight, tail]: | ||
| if not node: | ||
| continue | ||
| node.visible = revealed | ||
| node.modulate = Color.WHITE if revealed else Color.TRANSPARENT |
There was a problem hiding this comment.
You could add all those to a Node2D called "VisibleThings" and set visible and modulate on that one, instead of iterating 4 sprites. With that, you can also use modulate instead of self_modulate for the highlight above. And also reduce the amount of tracks in the "reveal" animation:
There was a problem hiding this comment.
whit the highlight and the tail probably because the shadow I putted a little bit of opacity y el sprite 2D complicate too jajaja
There was a problem hiding this comment.
emmmmm better no for now, i tried whit the highlight and the tail but it ocurred something, I don't know jjajaja
There was a problem hiding this comment.
i tried it but I think with the new script or something goes in conflict each other and then the highlight and the tail when I tried it did'nt appear jajajjaa
2 participants
Collectible threads: Integrate more visually enticing animations
Here is my contribution, now the threads can move up and down, floating in the air, also there are their tales and lights, and the shadow has a little animation in default.
Resolves [Collectible threads: Integrate more visually enticing animations #2876] (#2876)