Signpost: Add non-directional variant #2933

[joshuajenner]

Updated the sign sprite to include a non-directional variant.
Updated the update_appearance() function in the sign scene to use the correct frame when setting the direction variable.

Resolves: #2933

[manuq]

This is looks really promising! It works, I'm only requesting code improvements.

[github-actions]

Test build no longer available.

[joshuajenner]

Thanks for the feedback.

Undid the edit to the third party sprite, and moved the edited sprite to the non-cc0 folder.
Added a Frame enum.
Set the Appearance sprite to use unique name.

[manuq]

Thanks for the feedback.

Undid the edit to the third party sprite, and moved the edited sprite to the non-cc0 folder.

Sorry for confusing you in #2936 (comment) . As you can see, English is not my native language :) I wanted to say that the change was fine. For context:

• PixelFrog is not going to update the CC0 asset pack, so I think is fine changing it as you did.
• PixelFrog gave us permission to ship the non-CC0 asset pack as-is. If they ever want to update the pack we should ask them for permission again.

Don't worry, I will revert the commit and merge, since I caused the confusion.

Added a Frame enum. Set the Appearance sprite to use unique name.

Looks good. Thanks!

[manuq]

The other signpost scene changed here was a duplicate in a StoryQuest. Since there weren't any customizations, I went ahead and replaced the single instantiation by the main one, and removed it.