feat(cli): the document cache takes the config directory - #204
Draft
ecalifornica wants to merge 1 commit into
Draft
feat(cli): the document cache takes the config directory#204ecalifornica wants to merge 1 commit into
ecalifornica wants to merge 1 commit into
Conversation
|
🔍 Preview deployed: https://2989f897.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-cache
branch
from
August 14, 2026 19:49
0047733 to
7debfdd
Compare
ecalifornica
marked this pull request as ready for review
August 17, 2026 17:02
ecalifornica
force-pushed
the
robert/config-cache
branch
from
August 18, 2026 20:09
7debfdd to
b177ed1
Compare
ecalifornica
changed the title
ecalifornica
force-pushed
the
robert/config-cache
branch
from
August 25, 2026 20:23
b177ed1 to
086b12d
Compare
ecalifornica
marked this pull request as draft
August 25, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #184; path-cli only. The cache, the sync engine's record surfaces, and the
queryscan takeconfig_dir: &Path(20 signatures), so no function below the command layer takes&Configfor its config directory alone andcache.rsreads no environment variable. Command modules resolveConfig::config_dironce and pass the path;cmd_config::runtakes&Configbecause it imported the freeconfig_dir(), which this PR deletes. Behavior change:p export,resume, andqueryresolve the config directory before reading their input, so they error without$HOME,$USERPROFILE, or$TOOLPATH_CONFIG_DIReven for a file input.