fix: boxed_zoom_rect not in foreground#242
Conversation
|
View snapshot changes at kitdiff |
|
Can we get this merged? I ran into the same issue and it's really bad for PlotImage because the selection box can't be seen at all. |
lucasmerlin
left a comment
There was a problem hiding this comment.
I think moving this down would introduce a frame delay when moving the camera.
Maybe instead we can return a Vec from handle_interaction that we can later add to the painter to solve the ordering issue?
|
This PR fixes the mentioned bug, I've been using it for the last few months and didn't notice any issue that could have been caused by it. Also, the visual testing of the app resulting from this library should be improved, have it been done better this issue would't have come up. |
This PR reverts the regression introduced in the 0.35.0 release, where the
boxed_zoom_rectgets painted behind the plot's content (shapes, images, grid, etc...), effectively restoring the behaviour present up to the 0.34.0 release, bringing back the drawn rectangle to the foreground.The issue and the resulting appearence are thoroughly documented in the issue this PR addresses: