fix: avoid ninja object path collisions - #133
Open
aman-sharma-dev wants to merge 1 commit into
Open
Conversation
Signed-off-by: aman-sharma-dev <amansharma.devloper@gmail.com>
aman-sharma-dev
requested review from
hshanmug12 and
srpatcha
as code owners
September 11, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Ninja object-file path collisions when source files in the same target have the same basename but different extensions.
Previously, sources such as
src/start.candsrc/start.Sboth mapped tosrc/start.o, causing Ninja to reject the generated build graph due to duplicate outputs.Object paths now preserve the source extension, producing
start.c.oandstart.S.o.Type of Change
Changes
Testing
ctest --test-dir build --output-on-failure)Focused Ninja backend tests: 19 passed.
Ninja dry-run validation (
ninja -n): passed.Full Python test suite: 667 passed, 10 failed, 7 skipped. The 10 failures were reproduced against the original backend and are unrelated to this change.
Pre-Submission Checklist
-Wall -Wextra -Werrorfor C)Related Issues
N/A
Screenshots / Logs
N/A
Additional Notes
The full-suite failures are pre-existing and reproduce without this change.