PAN-3641

[eltmon]

Issue: #3641

Summary by CodeRabbit

• Bug Fixes
  • Improved review convoy liveness detection using the most recent effective reviewer activity.
  • Active reviews now remain in progress when current reviewers show fresh activity.
  • Activity from previous review runs is correctly ignored, allowing stale convoys to be detected.
  • Orphan recovery now preserves active review status without resetting retry counts.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c4f7aba2-9795-48e7-b201-0118101c93bb

📥 Commits

Reviewing files that changed from the base of the PR and between 62b7c24 and 637df64.

📒 Files selected for processing (3)

• src/lib/cloister/__tests__/pan-2341-orphan-redispatch.test.ts
• src/lib/cloister/__tests__/review-convoy-liveness.test.ts
• src/lib/cloister/review-convoy-liveness.ts

---

📝 Walkthrough

Walkthrough

Changes

The convoy liveness evaluator now uses effective reviewer activity and limits activity checks to the coordinator’s review run. Regression tests cover active current-run reviews, stale earlier-run activity, and orphan recovery behavior.

Review convoy liveness

Layer / File(s)	Summary
Update convoy liveness evaluation src/lib/cloister/review-convoy-liveness.ts	The evaluator retains the coordinator record, scopes agents by reviewRunId, and checks persisted activity before effective activity.
Validate active-run and orphan behavior src/lib/cloister/__tests__/*	Tests verify that current-run effective activity prevents recovery, while earlier-run activity does not keep the convoy active.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

• eltmon/overdeck issue 3641 — The change implements effective-activity checks and current-run scoping for convoy liveness.

Possibly related PRs

• eltmon/overdeck#1630 — Both changes update convoy liveness logic and its tests.
• eltmon/overdeck#1784 — Both changes cover orphaned review redispatch and active review state.
• eltmon/overdeck#3529 — Both changes update orphan recovery decisions for review runs.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title references the tracked issue but does not describe the change to preserve active review convoys.	Replace the issue identifier with a concise description, such as "Preserve active review convoys during liveness checks."

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch strike/pan-3641

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}