0.75#1
Draft
elseform wants to merge 21 commits into
Draft
Conversation
- Restore existence guard in createLaunchBatches so existing batch files are preserved on update runs (was unconditionally overwriting) - Add legacy marker fallback in winetricksMarkersInstalled so wrappers set up before the v2 marker consolidation don't show as uninstalled - Tolerate native,builtin when native is expected in missingDllOverrides so old installs don't permanently show d3dcompiler_47 as needing update - Replace try? with do/catch + reporter.log in resolveCompatibleWinetricks so transient process errors don't silently trigger managed copy deletion and re-download - Use path comparison in setLaunchExecutable when mo2Path is known, so a differently-located exe named ModOrganizer.exe doesn't get MO2 env vars - Derive resetWrapperDerivedSettings values from SetupConfiguration() instead of inline literals to stay in sync with declared defaults - Promote commandValue parsing to SetupCLICommandTools.value(for:in:) to eliminate the duplicate implementation in AppModel+WrapperSettings - Use hasPrefix instead of contains when stripping DXMT env lines from mo2.bat to avoid incorrectly removing echo/comment lines Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bug fixes from code review; all tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing