chore: simplify payload ownership updates

[thweetkomputer]

Context

VersionedPayload and NonVersionedPayload handled null incoming payloads with explicit branches even though release() plus reset() already provides the same ownership semantics. NonVersionedPayload::DeserializeCurrentPayload() also allocated a default payload that was immediately replaced by the deserialized object.

Behavior before and after

There is no intended observable behavior change. Passing a null payload still clears the current payload, passing a non-null payload still transfers ownership, and deserialization still replaces the current payload with the decoded object.

Implementation

• Use release() and reset() directly in both PassInCurrentPayload() implementations.
• Remove the immediately discarded allocation from NonVersionedPayload::DeserializeCurrentPayload().

Design decisions and alternatives

The change preserves the existing type conversion and ownership flow while removing redundant control flow and allocation. No public API or serialized format changes.

Test plan

• Unit/CTest coverage
• Parent-project integration or manual validation
• Formatting/build checks
• Recovery, compatibility, or performance validation, when relevant
• Documentation updated, when behavior changed

Commands and results:

Not run at the request of the author.

Risk assessment

Low. The null and non-null ownership outcomes are unchanged. The only removed runtime work is an unused default allocation before deserialization.

Rollback plan

Revert commit 617a2f7.

Reviewer guide

Review the VersionedPayload::PassInCurrentPayload(), NonVersionedPayload::PassInCurrentPayload(), and NonVersionedPayload::DeserializeCurrentPayload() changes in tx_service/include/cc/cc_entry.h.

Follow-up work

None.

Summary by CodeRabbit

• Bug Fixes
  • Improved payload replacement and deserialization consistency.
  • Ensured current payloads are refreshed from released or deserialized data without relying on existing payload state.

[coderabbitai]

Walkthrough

This change modifies payload replacement logic in cc_entry.h. VersionedPayload::PassInCurrentPayload and NonVersionedPayload::PassInCurrentPayload now unconditionally replace cur_payload_. NonVersionedPayload::DeserializeCurrentPayload deserializes into a new temporary object instead of reusing an existing one.

Changes

Payload replacement simplification

Layer / File(s)	Summary
Unconditional payload replacement tx_service/include/cc/cc_entry.h	PassInCurrentPayload for both VersionedPayload and NonVersionedPayload removes null-check branches and always assigns the released pointer to cur_payload_. DeserializeCurrentPayload for NonVersionedPayload always constructs a new temporary ValueT and replaces the current payload, instead of conditionally reusing an existing object.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: liunyl

Poem

A hop, a skip, a null check gone,
The payload swaps with each new dawn.
No more checks to slow the way,
Just release and replace, come what may. 🐇
Carrots stacked, the code runs clean today!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: simplifying payload ownership updates.
Description check	✅ Passed	The description covers all required sections, explains behavior and implementation, documents risks and rollback, and states that validation was not run.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/simplify-payload-ownership

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

tx_service/include/cc/cc_entry.h (1)

817-817: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Document the ownership and type precondition.

payload.release() transfers ownership to cur_payload_. A non-null payload must refer to a ValueT object. Add a short comment or API documentation to both PassInCurrentPayload methods that states these requirements.

As per coding guidelines, document non-obvious invariants and operational constraints, including ownership and lifetime.

Also applies to: 879-880

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tx_service/include/cc/cc_entry.h` at line 817, Document both
PassInCurrentPayload methods to state that payload ownership transfers to
cur_payload_ via release, and that any non-null payload must point to a ValueT
object. Keep the documentation concise and place it with each method’s API
comment.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tx_service/include/cc/cc_entry.h`:
- Line 817: Document both PassInCurrentPayload methods to state that payload
ownership transfers to cur_payload_ via release, and that any non-null payload
must point to a ValueT object. Keep the documentation concise and place it with
each method’s API comment.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 825096bb-da38-4949-aeb5-30071fa20bcf

📥 Commits

Reviewing files that changed from the base of the PR and between b146a51 and 617a2f7.

📒 Files selected for processing (1)

• tx_service/include/cc/cc_entry.h