Skip to content

Adapt EloqStore IO QoS configuration #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thweetkomputer wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adapt EloqStore IO QoS configuration #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb80ae
Adapt EloqStore IO QoS configuration
thweetkomputer Jul 30, 2026
ceffdc8
Format EloqStore IO QoS configuration
thweetkomputer Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 58 additions & 8 deletions store_handler/eloq_data_store_service/eloq_store_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,28 @@ DEFINE_uint32(eloq_store_io_queue_size,
DEFINE_uint32(eloq_store_max_inflight_write,
64 << 10,
"EloqStore max inflight write.");
DEFINE_uint32(eloq_store_max_write_batch_pages,
32,
"EloqStore max write batch pages.");
DEFINE_uint64(eloq_store_disk_rate_limit_iops,
275000,
"EloqStore per-disk IOPS limit; 0 disables IOPS limiting.");
DEFINE_uint64(
eloq_store_disk_rate_limit_mbps,
0,
"EloqStore per-disk throughput limit in MB/s; 0 disables byte limiting.");
DEFINE_uint32(eloq_store_rate_limit_burst_ms,
2,
"EloqStore rate-limit burst capacity in milliseconds.");
DEFINE_string(
eloq_store_rate_limit_io_unit,
"2KB",
"EloqStore IO size charged as one operation by the rate limiter.");
DEFINE_uint32(eloq_store_rate_bg_ratio,
25,
"EloqStore percentage of the rate budget reserved for "
"background IO.");
DEFINE_uint32(
eloq_store_max_inflight_io,
0,
"EloqStore maximum in-flight device commands per shard; 0 disables it.");
DEFINE_uint32(eloq_store_coroutine_stack_size,
32 * 1024,
"EloqStore coroutine stack size.");
Expand Down Expand Up @@ -646,12 +665,43 @@ EloqStoreConfig::EloqStoreConfig(const INIReader &config_reader,
"eloq_store_max_inflight_write",
FLAGS_eloq_store_max_inflight_write);
eloqstore_configs_.max_inflight_write /= eloqstore_configs_.num_threads;
eloqstore_configs_.max_write_batch_pages =
!CheckCommandLineFlagIsDefault("eloq_store_max_write_batch_pages")
? FLAGS_eloq_store_max_write_batch_pages
eloqstore_configs_.disk_rate_limit_iops =
!CheckCommandLineFlagIsDefault("eloq_store_disk_rate_limit_iops")
? FLAGS_eloq_store_disk_rate_limit_iops
: config_reader.GetInteger("store",
"eloq_store_disk_rate_limit_iops",
FLAGS_eloq_store_disk_rate_limit_iops);
eloqstore_configs_.disk_rate_limit_mbps =
!CheckCommandLineFlagIsDefault("eloq_store_disk_rate_limit_mbps")
? FLAGS_eloq_store_disk_rate_limit_mbps
: config_reader.GetInteger("store",
"eloq_store_disk_rate_limit_mbps",
FLAGS_eloq_store_disk_rate_limit_mbps);
eloqstore_configs_.rate_limit_burst_ms =
!CheckCommandLineFlagIsDefault("eloq_store_rate_limit_burst_ms")
? FLAGS_eloq_store_rate_limit_burst_ms
: config_reader.GetInteger("store",
"eloq_store_rate_limit_burst_ms",
FLAGS_eloq_store_rate_limit_burst_ms);
std::string rate_limit_io_unit =
!CheckCommandLineFlagIsDefault("eloq_store_rate_limit_io_unit")
? FLAGS_eloq_store_rate_limit_io_unit
: config_reader.GetString("store",
"eloq_store_rate_limit_io_unit",
FLAGS_eloq_store_rate_limit_io_unit);
eloqstore_configs_.rate_limit_io_unit = parse_size(rate_limit_io_unit);
eloqstore_configs_.rate_bg_ratio =
!CheckCommandLineFlagIsDefault("eloq_store_rate_bg_ratio")
? FLAGS_eloq_store_rate_bg_ratio
: config_reader.GetInteger("store",
"eloq_store_rate_bg_ratio",
FLAGS_eloq_store_rate_bg_ratio);
eloqstore_configs_.max_inflight_io =
!CheckCommandLineFlagIsDefault("eloq_store_max_inflight_io")
? FLAGS_eloq_store_max_inflight_io
: config_reader.GetInteger("store",
"eloq_store_max_write_batch_pages",
FLAGS_eloq_store_max_write_batch_pages);
"eloq_store_max_inflight_io",
FLAGS_eloq_store_max_inflight_io);
eloqstore_configs_.coroutine_stack_size =
!CheckCommandLineFlagIsDefault("eloq_store_coroutine_stack_size")
? FLAGS_eloq_store_coroutine_stack_size
Expand Down
2 changes: 1 addition & 1 deletion store_handler/eloq_data_store_service/eloqstore
Open in desktop
Submodule eloqstore updated 43 files
+2 −0 CLAUDE.md
+4 −0 benchmark/CMakeLists.txt
+254 −0 benchmark/eloq_store_bm.cc
+12 −6 benchmark/eloq_store_bm.h
+575 −0 benchmark/interference_bench.cpp
+8 −0 benchmark/main.cpp
+30 −0 benchmark/opts_interference.ini
+2 −2 db_stress/README.md
+2 −1 db_stress/crash_test.py
+3 −1 db_stress/db_stress_gflags.cpp
+8 −1 docs/architecture/02-runtime-and-lifecycle.md
+14 −0 docs/architecture/04-execution-model.md
+33 −1 docs/architecture/07-io-stack.md
+6 −0 docs/architecture/08-data-lifecycle.md
+638 −0 docs/design/io_qos.md
+366 −0 docs/design/io_qos_impl_plan.md
+264 −1 include/async_io_manager.h
+13 −0 include/eloq_store.h
+8 −3 include/eloqstore_metrics.h
+80 −14 include/fail_point.h
+107 −6 include/kv_options.h
+12 −7 include/storage/shard.h
+46 −1 include/tasks/task.h
+32 −0 include/types.h
+11 −0 include/utils.h
+128 −0 scripts/io_calibration_sweep.sh
+459 −3 src/async_io_manager.cpp
+21 −5 src/eloq_store.cpp
+56 −2 src/kv_options.cpp
+4 −0 src/storage/object_store.cpp
+122 −41 src/storage/shard.cpp
+12 −0 src/tasks/read_task.cpp
+5 −2 src/tasks/task.cpp
+9 −10 src/tasks/write_task.cpp
+1 −0 tests/CMakeLists.txt
+0 −2 tests/batch_write.cpp
+9 −13 tests/cloud.cpp
+16 −4 tests/common.cpp
+12 −1 tests/common.h
+12 −1 tests/data_page_cache.cpp
+49 −6 tests/eloq_store_test.cpp
+390 −0 tests/io_qos.cpp
+10 −8 tests/large_value_benchmark.cpp
Loading