Skip to content

chore: update data_substrate for brpc eventfd wakeup - #554

Open
thweetkomputer wants to merge 8 commits into
mainfrom
agent/test-data-substrate-brpc-eventfd
Open

chore: update data_substrate for brpc eventfd wakeup#554
thweetkomputer wants to merge 8 commits into
mainfrom
agent/test-data-substrate-brpc-eventfd

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Context

Consume the Data Substrate integration of the eventfd worker-wakeup support merged in eloqdata/brpc#25, through eloqdata/tx_service#540.

Changes

  • Advance data_substrate to 207f289b1e2f0a6953cfe1bb1b0933838de2eeb2.
  • That revision pins brpc master at c12822d4931a59a9c2cc42df061975e114e93590.

No EloqKV command behavior, data format, or user configuration changes are included.

Validation

git diff --check origin/main...HEAD
PASS

The full EloqKV build and integration suites are running in this PR's CI; they were not rerun locally for this pointer-only update.

Risk and rollback

The change affects worker idle waiting and shutdown when io_uring is enabled. Possible regressions include missed wakeups, shutdown hangs, or unsupported runner kernels. Non-io_uring helper processes retain the condition-variable path. Revert this PR to restore the previous data_substrate pointer.

Reviewer guide

Verify data_substrate at 207f289b1e2f0a6953cfe1bb1b0933838de2eeb2, then follow its brpc pointer to c12822d4931a59a9c2cc42df061975e114e93590.

Summary by CodeRabbit

  • Chores
    • Updated the underlying data substrate to a newer version, including the latest fixes and improvements.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 031f3f3b-4ae5-4a37-b42d-f2a4f36cf9d8

📥 Commits

Reviewing files that changed from the base of the PR and between 08f1e53 and 167a82c.

📒 Files selected for processing (1)
  • data_substrate
🚧 Files skipped from review as they are similar to previous changes (1)
  • data_substrate

Walkthrough

The PR updates the data_substrate submodule reference from commit 63db0ecbe3cd04e23282aa61af3961491647bddf to commit 39171c94549baf6d092ed4d24504fb94afd62785.

Changes

Submodule update

Layer / File(s) Summary
Update data_substrate reference
data_substrate
The submodule pointer now references commit 39171c94549baf6d092ed4d24504fb94afd62785.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: trigger-ci

Suggested reviewers: liunyl, starrysky9959

Poem

A rabbit checks the pointer with care,
A newer substrate waits there.
One commit hops ahead,
The old hash leaves the thread,
Clean links in the burrowed lair.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the data_substrate update and its purpose for brpc eventfd wakeup support.
Description check ✅ Passed The description explains the context, pointer changes, validation, risks, rollback, and reviewer focus, but omits several template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/test-data-substrate-brpc-eventfd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thweetkomputer
thweetkomputer marked this pull request as ready for review August 4, 2026 06:40

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@data_substrate`:
- Line 1: Update the data_substrate gitlink to the intended commit
021556ba9c9fadb14ab6a2b5dfbff2425874f686 so the CMakeLists.txt build uses the
PR’s targeted Data Substrate revision; if
8d0f3258c4e533a33068437dfd7fca33c521f6a4 is intentional, instead retarget the PR
accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89693543-a1f7-4997-94cd-4166b5572789

📥 Commits

Reviewing files that changed from the base of the PR and between dd05387 and eb40cfd.

📒 Files selected for processing (1)
  • data_substrate

Comment thread data_substrate Outdated
@thweetkomputer thweetkomputer changed the title test: validate brpc eventfd wakeup integration chore: update data_substrate for brpc eventfd wakeup Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant