chore: update data_substrate for brpc eventfd wakeup - #554
chore: update data_substrate for brpc eventfd wakeup#554thweetkomputer wants to merge 8 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR updates the ChangesSubmodule update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data_substrate`:
- Line 1: Update the data_substrate gitlink to the intended commit
021556ba9c9fadb14ab6a2b5dfbff2425874f686 so the CMakeLists.txt build uses the
PR’s targeted Data Substrate revision; if
8d0f3258c4e533a33068437dfd7fca33c521f6a4 is intentional, instead retarget the PR
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 89693543-a1f7-4997-94cd-4166b5572789
📒 Files selected for processing (1)
data_substrate
Context
Consume the Data Substrate integration of the eventfd worker-wakeup support merged in eloqdata/brpc#25, through eloqdata/tx_service#540.
Changes
data_substrateto207f289b1e2f0a6953cfe1bb1b0933838de2eeb2.masteratc12822d4931a59a9c2cc42df061975e114e93590.No EloqKV command behavior, data format, or user configuration changes are included.
Validation
The full EloqKV build and integration suites are running in this PR's CI; they were not rerun locally for this pointer-only update.
Risk and rollback
The change affects worker idle waiting and shutdown when io_uring is enabled. Possible regressions include missed wakeups, shutdown hangs, or unsupported runner kernels. Non-io_uring helper processes retain the condition-variable path. Revert this PR to restore the previous
data_substratepointer.Reviewer guide
Verify
data_substrateat207f289b1e2f0a6953cfe1bb1b0933838de2eeb2, then follow its brpc pointer toc12822d4931a59a9c2cc42df061975e114e93590.Summary by CodeRabbit