Skip to content

fix: include data_substrate TTL compaction filter fix - #486

Merged
thweetkomputer merged 2 commits into
mainfrom
agent/bump-data-substrate-ttl-compaction-filter
Aug 3, 2026
Merged

fix: include data_substrate TTL compaction filter fix#486
thweetkomputer merged 2 commits into
mainfrom
agent/bump-data-substrate-ttl-compaction-filter

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Context

Includes the Data Substrate fix from eloqdata/tx_service#539 so EloqDoc CI can validate the corrected RocksDB/RocksDB-Cloud TTL compaction-filter value parsing.

This PR intentionally points at the dependency PR head (93ac9eb) and must remain draft until the dependency is merged. After tx_service#539 is squash-merged, refresh the gitlink to the resulting commit on tx_service/main before merging this PR.

Behavior before and after

Before, EloqDoc referenced Data Substrate 9125a4c, before the corrected DSS RocksDB TTL value-header decoder.

After, EloqDoc references 93ac9eb, where the filter decodes the version timestamp and TTL consistently, uses a per-compaction timestamp snapshot, and is covered by the RocksDB Cloud S3 unit-test configuration.

Implementation

  • Update only src/mongo/db/modules/eloq/data_substrate from 9125a4c to 93ac9eb.
  • Depend on tx_service#539 for the TTL implementation and unit-test changes.
  • Because EloqDoc's previous pointer predates the dependency PR base, this bump also includes tx_service #535 (compile-warning fixes) and #536 (removal of DynamoDB and Bigtable backends).

Design decisions and alternatives

This is a dependency-validation PR against the open tx_service branch. It does not duplicate the storage-engine change in EloqDoc. The final parent gitlink will be updated after the dependency is merged, in accordance with the repository merge policy.

Test plan

  • EloqDoc build/integration tests: not run locally; delegated to this PR's CI.
  • git diff --check origin/main...HEAD: passed.
  • tx_service#539 unit-tests on amd64 and arm64: passed.
  • tx_service#539 Cloud S3 suite: 52/52 passed on both architectures, including TTLCompactionFilter-Test.
  • tx_service#539 log-service, clang-format, and cpplint checks: passed.

Risk assessment

The gitlink currently targets an open PR head rather than a commit reachable from tx_service/main; do not merge this PR in its current form. The dependency range also removes the retired DynamoDB and Bigtable backends, so reviewers should confirm EloqDoc has no remaining build-time dependency on those options. Runtime risk from #539 is limited to the RocksDB/RocksDB-Cloud TTL compaction path.

Rollback plan

Revert this PR, restoring the Data Substrate pointer to 9125a4c.

Reviewer guide

  1. Review and merge tx_service#539 first.
  2. Confirm EloqDoc CI passes with the removal of the retired storage backends.
  3. Verify the TTL compaction filter parses [encoded version timestamp][TTL][record] and its Cloud S3 unit test runs on both architectures.
  4. Before merging this parent PR, update the gitlink to the squash-merge commit and confirm it is reachable from tx_service/main.

Follow-up work

Refresh the submodule pointer after tx_service#539 is merged.

Summary by CodeRabbit

  • Chores
    • Updated an internal data component to a newer revision.
    • No user-visible features or behavior changes were introduced.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 825c4477-4a3b-4aa7-9ca4-5dedbd5221d4

📥 Commits

Reviewing files that changed from the base of the PR and between 1b43878 and 320bb0a.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate

Walkthrough

The pull request updates the data_substrate subproject reference to commit 63db0ecbe3cd04e23282aa61af3961491647bddf.

Changes

Data substrate update

Layer / File(s) Summary
Submodule pointer update
src/mongo/db/modules/eloq/data_substrate
The subproject reference changes to commit 63db0ecbe3cd04e23282aa61af3961491647bddf.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: trigger-ci

Suggested reviewers: liunyl

Poem

I hop past the pointer, precise and bright,
A new commit lands just right.
No source files change, no bugs to chase,
The substrate moves to a newer place.
— A rabbit 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the data_substrate gitlink update for the TTL compaction filter fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/bump-data-substrate-ttl-compaction-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thweetkomputer
thweetkomputer marked this pull request as ready for review August 3, 2026 00:29
@thweetkomputer
thweetkomputer requested a review from zhangh43 August 3, 2026 01:09
@thweetkomputer
thweetkomputer merged commit 4485b4b into main Aug 3, 2026
17 checks passed
@thweetkomputer
thweetkomputer deleted the agent/bump-data-substrate-ttl-compaction-filter branch August 3, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants