fix: include data_substrate TTL compaction filter fix - #486
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates the ChangesData substrate update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Context
Includes the Data Substrate fix from eloqdata/tx_service#539 so EloqDoc CI can validate the corrected RocksDB/RocksDB-Cloud TTL compaction-filter value parsing.
This PR intentionally points at the dependency PR head (
93ac9eb) and must remain draft until the dependency is merged. After tx_service#539 is squash-merged, refresh the gitlink to the resulting commit ontx_service/mainbefore merging this PR.Behavior before and after
Before, EloqDoc referenced Data Substrate
9125a4c, before the corrected DSS RocksDB TTL value-header decoder.After, EloqDoc references
93ac9eb, where the filter decodes the version timestamp and TTL consistently, uses a per-compaction timestamp snapshot, and is covered by the RocksDB Cloud S3 unit-test configuration.Implementation
src/mongo/db/modules/eloq/data_substratefrom9125a4cto93ac9eb.Design decisions and alternatives
This is a dependency-validation PR against the open tx_service branch. It does not duplicate the storage-engine change in EloqDoc. The final parent gitlink will be updated after the dependency is merged, in accordance with the repository merge policy.
Test plan
git diff --check origin/main...HEAD: passed.TTLCompactionFilter-Test.Risk assessment
The gitlink currently targets an open PR head rather than a commit reachable from
tx_service/main; do not merge this PR in its current form. The dependency range also removes the retired DynamoDB and Bigtable backends, so reviewers should confirm EloqDoc has no remaining build-time dependency on those options. Runtime risk from #539 is limited to the RocksDB/RocksDB-Cloud TTL compaction path.Rollback plan
Revert this PR, restoring the Data Substrate pointer to
9125a4c.Reviewer guide
[encoded version timestamp][TTL][record]and its Cloud S3 unit test runs on both architectures.tx_service/main.Follow-up work
Refresh the submodule pointer after tx_service#539 is merged.
Summary by CodeRabbit