Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"entity": {
"username": "roninjin10"
},
"content": "roninjin10: Focused on maintaining project dependencies by merging PR #10442 in elizaos/eliza, which updated the smithers-orchestrator package. This contribution involved modifying 3 files with a primary focus on configuration management."
"content": "roninjin10: Focused on maintaining project dependencies by merging PR #10442 in elizaos/eliza, which updated the smthrs package. This contribution involved modifying 3 files with a primary focus on configuration management."
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"entity": {
"username": "roninjin10"
},
"content": "roninjin10: Focused on maintaining project dependencies, successfully merging PR #10442 in elizaos/eliza to update the smithers-orchestrator from 0.22.0 to 0.26.1. This contribution involved modifying 3 files with a net increase of 46 lines of code. Their work this month was primarily centered on configuration management."
"content": "roninjin10: Focused on maintaining project dependencies, successfully merging PR #10442 in elizaos/eliza to update the smthrs from 0.22.0 to 0.26.1. This contribution involved modifying 3 files with a net increase of 46 lines of code. Their work this month was primarily centered on configuration management."
}
2 changes: 1 addition & 1 deletion github/contributors/roninjin10/summaries/day/2026-06-30.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
roninjin10: Focused on maintaining project dependencies by merging PR #10442 in elizaos/eliza, which updated the smithers-orchestrator package. This contribution involved modifying 3 files with a primary focus on configuration management.
roninjin10: Focused on maintaining project dependencies by merging PR #10442 in elizaos/eliza, which updated the smthrs package. This contribution involved modifying 3 files with a primary focus on configuration management.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
roninjin10: Focused on maintaining project dependencies, successfully merging PR #10442 in elizaos/eliza to update the smithers-orchestrator from 0.22.0 to 0.26.1. This contribution involved modifying 3 files with a net increase of 46 lines of code. Their work this month was primarily centered on configuration management.
roninjin10: Focused on maintaining project dependencies, successfully merging PR #10442 in elizaos/eliza to update the smthrs from 0.22.0 to 0.26.1. This contribution involved modifying 3 files with a net increase of 46 lines of code. Their work this month was primarily centered on configuration management.
8 changes: 4 additions & 4 deletions github/pr_comments.ndjson
Original file line number Diff line number Diff line change
Expand Up @@ -32600,10 +32600,10 @@
["IC_kwDOMT5cIs8AAAABKw-ouA", "PR_kwDOMT5cIs7zPsP8", "[sol-orch] Closing as exactly superseded by merged integration #16657 (`71ad59c4283ec247e26b446b793cfd5fc688c6b1`). Independent exact-head audit mapped proposal head `ed3e9fb04b1d484f386c56930d3eff41799d7ceb` into #16657: both quality-fork/test-realness contract implementations and their tests were byte-identical, while the proposal's unprivileged Playwright hunk in `quality-fork.yml` was preserved in the reviewed combined workflow. Fresh exact-head CI installed Chromium without sudo and completed the real Playwright suite 48/48 before manual merge. No unique delta remains here.", "2026-07-19T21:19:29Z", "2026-07-19T21:19:29Z", "0xSolace", "2026-07-19 23:27:18"]
["IC_kwDOMT5cIs8AAAABKv_QuQ", "PR_kwDOMT5cIs7zMaF8", "**Claude encountered an error after 1s** \u2014\u2014 [View job](https://github.com/elizaOS/eliza/actions/runs/29693820588)\n\n---\nI'll analyze this and get back to you.", "2026-07-19T15:56:01Z", "2026-07-19T15:56:20Z", "claude", "2026-07-19 23:27:18"]
["IC_kwDOMT5cIs8AAAABK6o7oQ", "PR_kwDOMT5cIs70Cc8m", "Heads up: #16703 just merged and formats 14 of these same 16 files (same biome output, overlapping scope). #16693 covers the remaining 2 (App.chat-overlay-first-run, notifications-boot). After a rebase this PR will likely be empty \u2014 if so it can be closed as superseded. Thanks for jumping on the Quality Extended red though, it was a real develop-baseline pain today. [sol-orch]", "2026-07-20T21:38:50Z", "2026-07-20T21:38:50Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK5uYrA", "PR_kwDOMT5cIs7zvfjQ", "The `Build` red here is a deterministic `develop`-baseline infra defect (electrobun self-extractor tar-unsafe `@aws-sdk/client-codebuild` nested path > 202 chars), not caused by this PR's diff. Fix in #16706 (skips the unused `@smithers-orchestrator/aws` infra AWS clients from the desktop runtime bundle; guard preserved). Re-run Build after #16706 lands. [sol-electrobun-build]", "2026-07-20T19:53:10Z", "2026-07-20T19:53:10Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK6uUnw", "PR_kwDOMT5cIs7zvfjQ", "Baseline unblocked: #16706 (electrobun tar-safe runtime-copy fix) merged to develop as `2b91780`. That was the deterministic `Build` failure hitting this PR \u2014 the `@smithers-orchestrator/aws` optional AWS infra clients (CodeBuild/ECS/CloudWatch-Logs) nesting tar-unsafe credential-provider paths past the 202-char Electrobun self-extractor limit. Not this PR's diff.\n\nBranch updated onto develop (now contains the fix); `Build [Quality (Fork)]` re-queued against the fixed baseline. Should go green once a runner picks it up.\n\n[sol-16706-green]", "2026-07-20T21:50:55Z", "2026-07-20T21:50:55Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK5uYrA", "PR_kwDOMT5cIs7zvfjQ", "The `Build` red here is a deterministic `develop`-baseline infra defect (electrobun self-extractor tar-unsafe `@aws-sdk/client-codebuild` nested path > 202 chars), not caused by this PR's diff. Fix in #16706 (skips the unused `@smthrs/aws` infra AWS clients from the desktop runtime bundle; guard preserved). Re-run Build after #16706 lands. [sol-electrobun-build]", "2026-07-20T19:53:10Z", "2026-07-20T19:53:10Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK6uUnw", "PR_kwDOMT5cIs7zvfjQ", "Baseline unblocked: #16706 (electrobun tar-safe runtime-copy fix) merged to develop as `2b91780`. That was the deterministic `Build` failure hitting this PR \u2014 the `@smthrs/aws` optional AWS infra clients (CodeBuild/ECS/CloudWatch-Logs) nesting tar-unsafe credential-provider paths past the 202-char Electrobun self-extractor limit. Not this PR's diff.\n\nBranch updated onto develop (now contains the fix); `Build [Quality (Fork)]` re-queued against the fixed baseline. Should go green once a runner picks it up.\n\n[sol-16706-green]", "2026-07-20T21:50:55Z", "2026-07-20T21:50:55Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABKzICuw", "PR_kwDOMT5cIs7ztlK7", "Manual proposal audit at `6d109776b8992412ce51dfcacdf41ce92a564847`: PASS, retain draft/manual-only.\n\n- choice contract is fail-closed to `android` / `android-cloud-hybrid`\n- default and standard command/artifact remain `android`, `bun run build:android`, and `eliza-android-debug`\n- hybrid command, full-SHA artifact name, APK filename, and provenance filename agree\n- provenance binds repository, exact commit, target, command, and JDK 21\n- focused native workflow contract: 5 pass / 0 fail / 49 assertions; YAML parse and diff check pass\n- exact hosted run `29722051581` succeeded and produced the named artifact\n\nNon-blocking hardening note: if the provenance text is later consumed outside GitHub Actions, add the copied APK SHA-256 to the text itself. Today GitHub provides the archive digest and the workflow generates output checksums, so this does not block the present workflow contract. No merge or auto-merge performed. [sol-orch]", "2026-07-20T07:11:10Z", "2026-07-20T07:11:10Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK5uZww", "PR_kwDOMT5cIs7ztkr_", "The `Build` red here is a deterministic `develop`-baseline infra defect (electrobun self-extractor tar-unsafe `@aws-sdk/client-codebuild` nested path > 202 chars), not caused by this PR's diff. Fix in #16706 (skips the unused `@smithers-orchestrator/aws` infra AWS clients from the desktop runtime bundle; guard preserved). Re-run Build after #16706 lands. [sol-electrobun-build]", "2026-07-20T19:53:11Z", "2026-07-20T19:53:11Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABK5uZww", "PR_kwDOMT5cIs7ztkr_", "The `Build` red here is a deterministic `develop`-baseline infra defect (electrobun self-extractor tar-unsafe `@aws-sdk/client-codebuild` nested path > 202 chars), not caused by this PR's diff. Fix in #16706 (skips the unused `@smthrs/aws` infra AWS clients from the desktop runtime bundle; guard preserved). Re-run Build after #16706 lands. [sol-electrobun-build]", "2026-07-20T19:53:11Z", "2026-07-20T19:53:11Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABKy_BnQ", "PR_kwDOMT5cIs7zpcMN", "Block-0 exact-head dispatch update:\n\nThe first `build:android:cloud-hybrid` workflow dispatch reached the package command but exposed that `run-mobile-build.mjs` did not yet admit or dispatch `android-cloud-hybrid`. Commit `a0dda5fc8dd872421c084d5bc4e7059f1f5c65f4` fixes the CLI allowlist, usage, and route to `runAndroidBuild(\"android-cloud-hybrid\")`, with focused contract coverage.\n\nValidation after that commit:\n- focused mobile target suite: 40 pass, 0 fail\n- exact stacked head Build Android run: success under JDK 21\n- run: https://github.com/elizaOS/eliza/actions/runs/29722051581\n- artifact: `eliza-android-cloud-hybrid-6d109776b8992412ce51dfcacdf41ce92a564847`\n\nWorkflow proposal remains separate in draft #16692 and is manual-merge only. [sol-orch]", "2026-07-20T06:49:09Z", "2026-07-20T06:49:09Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABKzH26g", "PR_kwDOMT5cIs7zpcMN", "Gate finisher update at `415d8e7d4cad57de27ddbe8bee88e397049c9e88`:\n\n- changed-file coverage is now honest for the native-build CLI: the existing Android target contract test spawns the exact `run-mobile-build.mjs android-cloud-hybrid` entrypoint and stops at a deterministic renderer-provenance guard before native files can change\n- the repository subprocess-entrypoint contract now classifies that orchestration CLI explicitly\n- hosted coverage run `29723517719`: 3 files / 55 tests pass, enforced files 100.00% + 98.53%, mean 99.26%, gate pass\n- required evidence rows now pass with non-visual N/A reasons and exact artifact run `29722051581`\n- no shared #16640 implementation file was rewritten in the finisher commit; no mobile tests were removed\n\nPR remains draft. [sol-orch]", "2026-07-20T07:10:50Z", "2026-07-20T07:10:50Z", "0xSolace", "2026-07-20 23:28:22"]
["IC_kwDOMT5cIs8AAAABKy6q9A", "PR_kwDOMT5cIs7zpZ7V", "Independent read-only merge-gate review completed against exact stacked head `cd70e1808cc7ebb364f38322803d01b16c704bba` on exact parent `16964a6e70263f20635c405f880856baff16aeda`. No concrete blockers found in the child-only diff. Marker injection, gated bridge installation, privileged write behavior, and packaged seed use are internally consistent. Verdict: **APPROVE**. This remains stack-gated on #16681 and must retarget/re-run full develop checks after the parent merges.\n\n[sol-orch]", "2026-07-20T06:36:58Z", "2026-07-20T06:36:58Z", "0xSolace", "2026-07-20 23:28:22"]
Expand Down Expand Up @@ -32965,7 +32965,7 @@
["IC_kwDOMT5cIs8AAAABLTBZzw", "PR_kwDOMT5cIs71IINw", "[sol-orch] TRACK B addendum: new commit 2c8f948fb ('honor target platform on Windows') pushed after my triage; re-reviewed. Scope: passes targetOS/targetArch through to matchesRuntimeVariant for the ffprobe-static bin filter + realpathSync.native in the coverage test expectation. Clean, in-family with the PR's Windows-correctness theme. Local re-run on new head: destructive-gate + bash + copy-runtime-node-modules coverage tests \u2192 164 pass / 0 fail. MERGE-on-full-green verdict unchanged; CI restarted for the new head, waiting it out.", "2026-07-23T00:46:28Z", "2026-07-23T00:46:28Z", "0xSolace", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLTLEYA", "PR_kwDOMT5cIs71IINw", "[sol-orch] TRACK B addendum 2: head moved again to 9ec84d7c7 ('test(cli): follow repository Biome pin'). Re-reviewed: template-biome-contract.test.ts now derives the pinned Biome version from the repo root package.json instead of hardcoding 2.5.4 \u2014 correct hardening given the 2.5.5 sweep, fails loudly if the pin is absent. Local run on new head: template-biome-contract 3 pass / 0 fail (plus prior 164/0 on the gate/bash/copy-runtime suites, unchanged by this commit). Scope note: PR is accreting small in-family fixes; fine, but please let CI finish a cycle \u2014 every push resets the starved runner queue and this PR has had 3 heads in 20 minutes. MERGE on full green stands.", "2026-07-23T01:16:58Z", "2026-07-23T01:16:58Z", "0xSolace", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLS90Mg", "PR_kwDOMT5cIs71H8rX", "[sol-orch] merge-track triage (TRACK B, 2026-07-22): claimed. Scope audit: diff vs merge-base is exactly bun.lock + smithers 0.28.0\u21920.29.0 alignment in two plugin manifests + regression test + AGENTS/CLAUDE doc line (the earlier 15-file stat was branch-lag artifact; real diff is 6 files, +349/-497). Local verification: `bun install --frozen-lockfile --ignore-scripts` clean; `bun test packages/app-core/scripts/assert-required-bundled-packages.test.ts` \u2192 26 pass / 0 fail. plugin-workflow local typecheck failure (@elizaos/shared) reproduces identically on develop baseline = pre-existing local-env, and PR CI lint-and-types passed. Not a cloud deploy path. Verdict: MERGE on full CI green (squash).", "2026-07-23T00:35:37Z", "2026-07-23T00:35:37Z", "0xSolace", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLUUJUA", "PR_kwDOMT5cIs71H8rX", "Superseded by develop commit f3c283b2183ca9dc16a0729447414d456fb55c80. That commit uses the stronger engine-only solution: it removes the unused smithers-orchestrator umbrella dependency from both runtime consumers and adds a regression contract forbidding its return, eliminating the tar-unsafe nested adapter graph instead of merely aligning its version.", "2026-07-23T04:41:43Z", "2026-07-23T04:41:43Z", "lalalune", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLUUJUA", "PR_kwDOMT5cIs71H8rX", "Superseded by develop commit f3c283b2183ca9dc16a0729447414d456fb55c80. That commit uses the stronger engine-only solution: it removes the unused smthrs umbrella dependency from both runtime consumers and adds a regression contract forbidding its return, eliminating the tar-unsafe nested adapter graph instead of merely aligning its version.", "2026-07-23T04:41:43Z", "2026-07-23T04:41:43Z", "lalalune", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLUE2GA", "PR_kwDOMT5cIs71Hoqi", "[sol-orch] merge-track triage: **APPROVE on review \u2014 merge QUEUED behind the promotion-r17 develop freeze** (hold posted on Discussion 14308). Repaired the two red gates on-branch:\n\n**Review:** correct fix for the double-ack. The handler already documented that mid-turn success callbacks were noise; this removes both the success callback and the invalid-op echo so every outcome reaches the planner via ActionResult and the planner's persona message is the single user-facing ack. -30/+12, no behavior change beyond message suppression.\n\n**Coverage gate:** pushed 80244d85ad0 adding two focused tests (success create + invalid op, both asserting the callback is never invoked; full trigger suite 14/14 locally after develop merge).\n\n**Evidence gate:** the domain-artifacts row cited the Discord transcript but carried no artifact link, which reads as blank to the checker. Verification artifacts for that row:\n- Before (from PR description): 3 delivered messages per trigger op \u2014 mechanical `Created trigger \"stretch reminder\" (once at 2026-07-22T22:55:10.345Z).` followed ~6s later by the planner ack.\n- After: 2 messages, trigger fire intact, local suite green: trigger.test.ts 14 passed (incl. the two new silent-ack pins).\n\nRepairing the body row to reference this comment next; will merge on green after the freeze lifts.", "2026-07-23T04:06:02Z", "2026-07-23T04:06:02Z", "0xSolace", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLUqqEw", "PR_kwDOMT5cIs71Hoqi", "Added handler-path tests for the lifecycle ops to clear the changed-file coverage gate on `packages/agent/src/actions/trigger.ts` (was 49.30% vs the 50% threshold).\n\nNew tests in `trigger.test.ts` (commit a69e680), same in-memory-runtime harness as the existing create-op tests:\n\n- **update** happy path \u2014 patches `displayName` + `intervalMs` via `taskId`, asserts the persisted `updateTask` patch carries the renamed description and a schedule re-armed off the new interval (`nextRunAtMs >= now + intervalMs`)\n- **update** failures \u2014 unknown UUID -> `TRIGGER_NOT_FOUND`, missing taskId -> `MISSING_TASK_ID`, and no `updateTask` persistence in either case\n- **delete** happy path \u2014 resolves the trigger by `displayName` fragment through `resolveTriggerRef` (no taskId) and asserts `deleteTask` got the right task id\n- **delete** not-found \u2014 empty trigger set -> `TRIGGER_NOT_FOUND` with the \"No triggers exist.\" text, nothing deleted\n- **toggle** happy path \u2014 flips a disabled trigger back on (default flip, no `enabled` param) and asserts the persisted metadata carries `enabled: true`\n\nVerified locally against the PR branch's exact blobs (trigger.ts + triggers/{runtime,scheduling,types}.ts + core triggerScheduling.ts, sha-matched): all 19 tests pass; trigger.ts coverage from this file is now 77.8% statements / 82.6% lines / 63.8% branches.\n\n[pr-queue-review]", "2026-07-23T05:32:18Z", "2026-07-23T05:32:18Z", "lalalune", "2026-07-23 23:28:06"]
["IC_kwDOMT5cIs8AAAABLSmrwQ", "PR_kwDOMT5cIs71HmUN", "Post-sync local verification COMPLETE on exact head `8852aeade9ceab6eac272395bd49b4d406672344` / base `ed98b7f2273e2f56cc80d254e0dda8bcdbbdff41`:\\n\\n- full `packages/agent` matrix: **347/347 test-file batches passed** (only intentional environment-gated skips)\\n- focused lifecycle/remote/PGlite: **52 passed / 3 intentional skips**\\n- `plugin-inbox`: **166 passed / 2 intentional skips**, lint, format, typecheck, build green\\n- agent lint, format, typecheck, build green\\n- changed production coverage: **65.23%** (required 50%)\\n- error-policy ratchet + diff-check green\\n\\nThe only local repository-wide residual remains the exact current-develop type-safety baseline mismatch (85 present vs 84 recorded), reproduced unchanged in a clean detached base worktree and documented in the PR body.", "2026-07-22T23:28:35Z", "2026-07-22T23:28:35Z", "NubsCarson", "2026-07-23 23:28:06"]
Expand Down
Loading