Allow conventional casing for picky WS server - #41
Merged
whatyouhide merged 1 commit intoAug 12, 2026
Conversation
Collaborator
|
Makes sense to me, thanks! |
Collaborator
|
This is out since yday on Hex btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm writing a client for a websocket server that requires case-sensitive headers when upgrading (I realize that's against spec, but it's not a server I have control over).
Right now,
Mint.WebSocket.upgrade(conn, ...)always sends downcased headers, but also, Mint always downcases headers.However, if I create a new Mint connection with
case_sensitive_headers: truethen they're indeed kept as-is, but MintWebSocket still tries to upgrade the conn with downcased headers.Therefore, this PR simply ProperCases the headers, for which Mint will downcase for everyone except those that specify
case_sensitive_headers: true.