Skip to content

Sort generated functions for deterministic builds #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whatyouhide merged 1 commit into from
Aug 11, 2026
Merged

Sort generated functions for deterministic builds #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/mint/http2/frame.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ defmodule Mint.HTTP2.Frame do

@spec inspect(tuple()) :: String.t()

for {type, _code} <- @types do
for {type, _code} <- Enum.sort(@types) do
def inspect(frame) when is_record(frame, unquote(type)) do
unquote(String.upcase(Atom.to_string(type))) <> Kernel.inspect(unquote(type)(frame))
end
Expand All @@ -63,7 +63,7 @@ defmodule Mint.HTTP2.Frame do
@spec flag_set?(byte(), atom(), atom()) :: boolean()
def flag_set?(flags, frame, flag_name)

for {frame, flags} <- @flags,
for {frame, flags} <- Enum.sort(@flags),
{flag_name, flag_value} <- flags do
defp set_flag(flags, unquote(frame), unquote(flag_name)), do: bor(flags, unquote(flag_value))

Expand Down Expand Up @@ -121,7 +121,7 @@ defmodule Mint.HTTP2.Frame do
:more
end

for {frame, type} <- @types do
for {frame, type} <- Enum.sort(@types) do
function = :"decode_#{frame}"

defp decode_contents(unquote(type), flags, stream_id, payload) do
Expand Down Expand Up @@ -482,7 +482,7 @@ defmodule Mint.HTTP2.Frame do
0x0D => :http_1_1_required
}

for {code, human_code} <- error_codes do
for {code, human_code} <- Enum.sort(error_codes) do
defp humanize_error_code(unquote(code)), do: unquote(human_code)
defp dehumanize_error_code(unquote(human_code)), do: unquote(code)
end
Expand Down
Loading