Skip to content

support max_body_size in child spec options#546

Merged
polvalente merged 1 commit into
elixir-grpc:masterfrom
aseigo:bug/allow-max-body-size-as-supervisor-arg
Jun 23, 2026
Merged

support max_body_size in child spec options#546
polvalente merged 1 commit into
elixir-grpc:masterfrom
aseigo:bug/allow-max-body-size-as-supervisor-arg

Conversation

@aseigo

@aseigo aseigo commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

With the new max_body_size support, body sizes can be controlled .. but the max_body_size parameter is not accepted as an option to the child spec of an endpoint.

We currently have this starting in a supervision tree:

children = [
      GrpcReflection,
      {
        GRPC.Server.Supervisor,
        [
          endpoint: Ujs.Router.Endpoint,
          port: port,
          start_server: true,
          max_body_size: Application.get_env(:ujs, :grpc_server_max_body_size)
        ]
      }
    ]

This currently fails due to the missing max_body_size key in the Keyword.validate call. This fixes that issue, and the above supervision tree starts and the max body size is correctly defined.

@polvalente polvalente merged commit dec9f85 into elixir-grpc:master Jun 23, 2026
14 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants