fix: Return a GRPC.RPCError in mint adapter#545
Conversation
|
For the tests (the reason the CI fails), I had to uncomment this locally on the grpc mix.exs to be able to run them: Do you want me to uncomment it (or point to |
|
@sleipnir for what it's worth, I think we should consider this a bug and release the fix in 1.0.1 |
I agree |
Please uncomment |
Done! Doing the deps get also updated the lock, it still had the grpc_core-rc.1 |
|
Tks @rockneurotiko we will release new version on Hex |
Fixes #544
Gun adapter always returns
{:error, %GRPC.RPCError{}}when an error happen while reading data, Mint on the other hand returns{:error, String.t()}, this PR changes the mint adapter to return{:error, %GRPC.RPCError{}}just like the gun adapter