Skip to content

fix: compile join right-side pipelines - #61

Open
icostan wants to merge 1 commit into
elixir-dux:mainfrom
icostan:fix/join-right-pipeline
Open

icostan wants to merge 1 commit into
elixir-dux:mainfrom
icostan:fix/join-right-pipeline

Conversation

@icostan

@icostan icostan commented Sep 22, 2026

Copy link
Copy Markdown

Summary

Fixes Dux.join/3 and Dux.asof_join/3 silently discarding pending operations on the right-hand pipeline.

Changes

  • Compile the complete right-hand %Dux{} pipeline instead of only its source.
  • Use the caller’s database connection when compiling nested pipelines.
  • Propagate nested setup SQL through the outer query build.
  • Add regression coverage for right-side:
    • filter
    • mutate
    • summarise
    • summarise_with
    • ASOF join operations
    • setup SQL generation

This prevents joins from silently operating on unfiltered or unaggregated right-side data.

Suffix handling is intentionally unchanged and remains follow-up work.

Testing

  • mix test test/dux/query_test.exs — 56 tests passed
  • Focused query/join/ASOF suites — 132 tests passed
  • mix format --check-formatted — passed

The full suite reached 899/900 tests; the unrelated distributed pivot_longer test still fails, while 16
PostgreSQL tests were invalidated by container startup failures. mix compile --warnings-as-errors
remains blocked by three pre-existing warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant