fix: find and jq honour -- as end-of-options - #98
Merged
Conversation
find -- -foo was still parsed as a predicate. jq -- . opened `.` as a file. Split at `--` and treat the remainder as operands: paths for find, filter then file for jq. exec/2 returns a result either way. Co-authored-by: Dave Lucia <davelucianyc@gmail.com>
davydog187
marked this pull request as ready for review
August 21, 2026 20:45
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
Follow-up from #89 / #83.
StdinOperand.split_end_of_options/1already covered most file-operand commands, butfindandjqstill mishandled--.User-visible behavior
jq . -- FILEis unchanged.JustBash.exec/2does not raise.GNU find still treats
find -- -fooas a predicate (a path starting with-ends the starting-point list). This change follows the #90 /ln.exreading:--ends parse and the remainder are operands, which is the POSIX reason--exists.GNU jq:
--only ends options. The first remaining positional is the filter (default.), then the file.Changes
findcallssplit_end_of_options/1and appends the remainder as paths, sofind -- -foosearches-foo.jqcollects leftover positionals from before--and concatenates them with the extra tokens after it: filter, then file.jq -- .no longer opens.as a path.find -- -foo,jq -- ., and extra--placements (only arg, file named--,--between two operands).Type of Change
Testing
Local gates:
Checklist
mix formatmix credoand addressed any issues