Skip to content

Fix inconsistent theme-color values across pages #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harit2207 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix inconsistent theme-color values across pages #4111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _backend/preload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
$sitewide['author'] = 'elementary, Inc.';
$sitewide['description'] = 'Thoughtful, capable, and ethical computing';
$sitewide['image'] = 'https://elementary.io/images/preview.png';
$sitewide['theme-color'] = '#3689e6';


// Autodetect website root path
$serverRoot = $_SERVER['DOCUMENT_ROOT'];
Expand Down
5 changes: 4 additions & 1 deletion _templates/header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@

<meta name="description" content="<?php echo !empty($page['description']) ? $page['description'] : $sitewide['description']; ?>">
<meta name="author" content="<?php echo !empty($page['author']) ? $page['author'] : $sitewide['author']; ?>">
<meta name="theme-color" content="<?php echo !empty($page['theme-color']) ? $page['theme-color'] : $sitewide['theme-color']; ?>">

<?php if (!empty($page['theme-color'])) { ?>
<meta name="theme-color" content="<?php echo $page['theme-color']; ?>">
<?php } ?>

<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:site" content="@elementary">
Expand Down
2 changes: 1 addition & 1 deletion docs/_mdr/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
'styles/docs.css'
);

$page['theme-color'] = '#403757';


include $Templates['Header'];
echo '<div class="row docs">';
Expand Down
2 changes: 1 addition & 1 deletion get-involved.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require_once __DIR__.'/_backend/preload.php';

$page['title'] = 'Get Involved with elementary OS';
$page['theme-color'] = '#3E4E54';


$page['styles'] = array(
'https://fonts.googleapis.com/css?family=Marck+Script',
Expand Down
2 changes: 1 addition & 1 deletion previous.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
require_once __DIR__.'/_backend/os-payment.php';

$page['title'] = 'Thank You for Downloading elementary OS';
$page['theme-color'] = '#3E4E54';


$page['scripts'] = array(
'scripts/download.js',
Expand Down
2 changes: 1 addition & 1 deletion thank-you.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require_once __DIR__.'/_backend/preload.php';

$page['title'] = 'Thank You for Downloading elementary OS';
$page['theme-color'] = '#3E4E54';


include $template['header'];
include $template['alert'];
Expand Down