Replace Evince with Papers - #1
Merged
Merged
Conversation
Because Papers requires gtk4 >= 4.17.1 but runtime 8 has 4.14.5
Otherwise I couldn't launch Papers with the following error:
papers: error while loading shared libraries: libppsdocument-4.0.so.5: cannot open shared object file: No such file or directory
So that future patches that requires granite don't depends on the patch to add granite::init()
Build options adapted from: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/blob/master/elements/sdk/gdk-pixbuf.bst Co-authored-by: Markus Göllnitz <camelcasenick@bewares.it>
Conflicts: org.gnome.papers.json
Conflicts: org.gnome.papers.json
Conflicts: org.gnome.papers.json
Conflicts: org.gnome.papers.json
Conflicts: org.gnome.papers.json
3 tasks
Conflicts: org.gnome.papers.json
Conflicts: org.gnome.papers.json
Member
|
There's little tiny things we could improve but not blocking imo. Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes elementary/evince#98
Based on https://github.com/flathub/org.gnome.Papers
Checklists