fix: window stuck maximized on Wayland after early maximize() - #53125
Open
trop[bot] wants to merge 1 commit into
Open
Conversation
A toplevel that calls Maximize() before the first xdg_toplevel.configure has been received could get stuck maximized: the compositor's state-less reply to the initial commit is compared against the optimistically applied kMaximized state and latches previously_maximized_ = true, after which Restore() re-requests kMaximized, is deduplicated, and unset_maximized is never sent. Make Restore() honour previously_maximized_ only when leaving the minimized or fullscreen state, and make TriggerStateChanges() also consult applied_state() so the unset request is not skipped while older bounds requests are still in flight. This should be upstreamed; the patch can be removed once that lands. Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
5 tasks
trop
Bot
added
43-x-y
backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53063
See that PR for details.
Notes: Fixed
BrowserWindow.unmaximize()andrestore()having no effect on Wayland when the window was maximized immediately after creation.