Repository navigation
Format floats with the shortest round-trip digits - #23
Merged
Merged
Conversation
Property::setValue(float) published %f text (21.400000). It now publishes the shortest decimal that reads back as the same float, laid out like python-sdk's float text: 21.4, 40.0, 1e-05, 1e16. homie_format_float() and homie_format_double() in homie_datatype.h do the formatting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vz59zZzRfxFkWjW16egZoy
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`Property::setValue(float)` published `%f` text, so 21.4 went on the wire as `21.400000`. It now publishes the shortest decimal that reads back as the same float, in python-sdk's layout (`_format_float`: `repr()` without the exponent `+`): `21.4`, `40.0`, `1e-05`, `1e16`.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vz59zZzRfxFkWjW16egZoy