Skip to content

[EuiRange] Migrate to function component - #10098

Merged
angeles-mzb merged 4 commits into
elastic:mainfrom
angeles-mzb:9494-euirange-migrate-to-function-component
Oct 1, 2026
Merged

angeles-mzb merged 4 commits into
elastic:mainfrom
angeles-mzb:9494-euirange-migrate-to-function-component

Conversation

@angeles-mzb

@angeles-mzb angeles-mzb commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • What: This PR refactors EuiRange from a class component to a function component.
  • Why: closes [EuiRange] Migrate from class to function component #9494
  • Additional changes:
    • Updated the InputWithPopover Storybook (VRT) to open the popover via user interaction.
    • Updated related VRT baselines with the focused state.
    • Replaced non-null assertion for input
    • Added kibana's prep commit to update affected snapshots and assertions. Successful build here.

API Changes

No API changes

Screenshots

Before After
Screen.Recording.2026-09-30.at.10.27.04.mov
Screen.Recording.2026-09-30.at.10.26.06.mov

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

  • Verify parity with current production code
  • Verify the component works as expected in Storybook
  • Make sure updated VRT screenshots reflect relevant changes only
  • Verify prep commit is relevant

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@angeles-mzb angeles-mzb added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Sep 29, 2026
@angeles-mzb angeles-mzb self-assigned this Sep 29, 2026
@angeles-mzb angeles-mzb added the ci:regression-integration-test-kibana Run a Regression Integration Test in Kibana against this PR label Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Kibana Regression Integration Test

Status: 💔 Kibana CI failed
Branch: update-dependencies/1790756707
Kibana PR: elastic/kibana#294399

Please check Kibana CI logs for details.

@angeles-mzb angeles-mzb added ci:regression-integration-test-kibana Run a Regression Integration Test in Kibana against this PR and removed ci:regression-integration-test-kibana Run a Regression Integration Test in Kibana against this PR labels Sep 30, 2026
@angeles-mzb
angeles-mzb force-pushed the 9494-euirange-migrate-to-function-component branch from cd17512 to 83a5c57 Compare September 30, 2026 15:56
@angeles-mzb
angeles-mzb marked this pull request as ready for review September 30, 2026 16:10
@angeles-mzb
angeles-mzb requested a review from a team as a code owner September 30, 2026 16:10
@weronikaolejniczak
weronikaolejniczak self-requested a review October 1, 2026 09:41

@weronikaolejniczak weronikaolejniczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢 I tested and I noticed no regression. Just have 2 small comments. Thanks, Angeles!

Comment thread packages/eui/src/components/form/range/range.tsx
Comment thread packages/eui/src/components/form/range/range.tsx Outdated
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @angeles-mzb

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @angeles-mzb

@angeles-mzb
angeles-mzb merged commit 8b4aaaa into elastic:main Oct 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:regression-integration-test-kibana Run a Regression Integration Test in Kibana against this PR skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiRange] Migrate from class to function component

2 participants