feat(changelog): link: read side — schema field, scrub round-trip, marker resolution - #3924
Merged
Conversation
reakaleek
approved these changes
Aug 25, 2026
…rker resolution Adds the `link:` field to `ChangelogEntryDto`, `ChangelogEntry`, and `BundledEntry` so markers survive the scrub round-trip. `ChangelogContentScrubber` fast-paths a bare `link:`-only entry unchanged; a marker combined with content fields (title, type, prs) throws to catch authoring errors early. `ChangelogEntryMatcher` now detects markers in both `MatchChangelogsAsync` and `MatchChangelogContents`, suppresses them from bundle output, and resolves each to its parent entry after the main pass: - parent not found → hard error (a pipeline promise was broken) - parent is itself a marker (depth > 1) → hard error - parent found → marker silently dropped; parent included once No markers exist in S3 today so all new paths are inert on merge. Step 7 of the two-anchor plan (#3921). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mpdreamz
force-pushed
the
fix/changelog-link-read-side
branch
from
August 25, 2026 13:51
e5d2965 to
b5f92f4
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 7 of the two-anchor plan: adds the
link:read side so no bundler ever treats a pipeline-written marker as a malformed empty entry. No markers exist in S3 today — all new paths are inert on merge.LinktoChangelogEntryDto,ChangelogEntry, andBundledEntrysolink:survives the scrub round-tripChangelogContentScrubber: barelink:-only markers pass through unchanged;link:combined with content fields (title, type, prs) throwsInvalidOperationExceptionChangelogEntryMatcher: detects markers in both local and CDN paths, suppresses them from bundle output, resolves each to its parent after the main pass:Stack
This PR is stacked on
main; Step 8 (canonical keys + marker writing) stacks on top of this.Test plan
MarkerScrubTests: barelink:passes through;link:+ content fields throwsMarkerResolutionTests: one real + one marker → one output entry; missing parent → error; marker → marker chain → error; two markers same parent → one entry; no markers → unaffected🤖 Generated with Claude Code