fix: include license and tests in sdist - #661
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
CAOShurong
approved these changes
Aug 13, 2026
CAOShurong
left a comment
There was a problem hiding this comment.
Reviewed the exact PR head 055d03f627d41af111eff55ef5238d1363e7ab63 independently.
- The published PyPI 0.20.2 sdist has 0 license entries and 0 test entries.
- A build from this PR contains the byte-identical
LICENSE.txt(SHA-25606eb1c44...) and 92 test entries in the sdist. - The wheel contains the license under
.dist-info/licenses/and contains no tests. - The 36 non-CLI test scripts passed in a clean wheel-installed Python 3.13 environment; the module CLI path also passed separately and produced a 13,419-byte DOCX.
- The repository's flake8 command and
git diff --checkboth passed.
The latest pdm-backend also happens to include these files implicitly when rebuilding the base commit today, but declaring source-includes explicitly makes the intended sdist contents robust instead of depending on backend-default drift. This looks correct and focused to me.
OpenAI Codex assisted with the reproduction and verification. I reviewed the diff and the observed results before approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #660
Summary
LICENSE.txtin PDM source distributionstests/tree for downstream packagers without adding it to wheelsTesting
uv build(sdist and wheel)LICENSE.txtuv run --project .. --frozen python runtests.py(fromtests/)uv run --frozen flake8 docxtpl tests setup.py --count --max-line-length=127 --show-source --statistics