Fix CI build: unwrap responsible pid explicitly - #1
Open
eko wants to merge 1 commit into
Open
Conversation
The `responsibleFunction.map { $0(pid) }.flatMap { ... } ?? pid` chain
inferred `owner` as a non-optional `pid_t` on Swift 6.3 but as `pid_t?`
on the toolchain CI runs, which broke every use of `owner` below it and
failed the build (and therefore the test job). Replace the chain with an
explicit `responsibleFunction?(pid) ?? 0` and a plain ternary so the type
is unambiguous on every Swift version.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013A9rfM4sZpbLNzgX771ns8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Unit testsjob failed to compile (not on an assertion):In
AudioApp.running(), this chaininfers
owneraspid_ton Swift 6.3 (local) but aspid_t?on the toolchain the GitHub runner uses, so every use ofownerbelow it fails to build.Fix
Replace the map/flatMap chain with an explicit form whose type is unambiguous on every Swift version:
No behaviour change.
swift build(clean) and all 64 tests pass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_013A9rfM4sZpbLNzgX771ns8