Skip to content

docs: acknowledge Y4tacker security report#6038

Merged
killagu merged 1 commit into
nextfrom
agent/add-y4tacker-security-acknowledgement
Jul 21, 2026
Merged

docs: acknowledge Y4tacker security report#6038
killagu merged 1 commit into
nextfrom
agent/add-y4tacker-security-acknowledgement

Conversation

@killagu

@killagu killagu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Add a Security Acknowledgements section to SECURITY.md and credit Y4tacker for responsibly reporting the command injection vulnerability in @eggjs/security's escapeShellArg helper.

References

Validation

Documentation-only change; verified the acknowledgement and fix links in the rendered Markdown structure.

Summary by CodeRabbit

  • Documentation
    • Added a Security Acknowledgements section recognizing a researcher for responsibly reporting a command injection issue.
    • Included references to the relevant fixes across supported versions.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae69d44e-1033-4d4a-9672-60c06cf98105

📥 Commits

Reviewing files that changed from the base of the PR and between 196f11d and 24e53d6.

📒 Files selected for processing (1)
  • SECURITY.md

📝 Walkthrough

Walkthrough

SECURITY.md now includes a Security Acknowledgements section crediting Y4tacker for responsibly disclosing a command injection issue related to escapeShellArg, with links to fixes in the 4.x and 3.x branches.

Changes

Security acknowledgement

Layer / File(s) Summary
Add security acknowledgement
SECURITY.md
Adds acknowledgement text and a table listing the researcher, vulnerability, and related fixes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/add-y4tacker-security-acknowledgement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SECURITY.md file to add a 'Security Acknowledgements' section, thanking a security researcher for reporting a command injection vulnerability. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying egg with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24e53d6
Status: ✅  Deploy successful!
Preview URL: https://d61ab5af.egg-cci.pages.dev
Branch Preview URL: https://agent-add-y4tacker-security.egg-cci.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying egg-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24e53d6
Status: ✅  Deploy successful!
Preview URL: https://5e78754e.egg-v3.pages.dev
Branch Preview URL: https://agent-add-y4tacker-security.egg-v3.pages.dev

View logs

@killagu
killagu marked this pull request as ready for review July 21, 2026 01:39
Copilot AI review requested due to automatic review settings July 21, 2026 01:39
@killagu
killagu merged commit 4864e03 into next Jul 21, 2026
10 of 11 checks passed
@killagu
killagu deleted the agent/add-y4tacker-security-acknowledgement branch July 21, 2026 01:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s security policy documentation by adding an acknowledgement section to credit a security researcher for responsible disclosure related to @eggjs/security.

Changes:

  • Add a new Security Acknowledgements section to SECURITY.md.
  • Credit Y4tacker for reporting a command injection issue in escapeShellArg, with links to the 4.x and 3.x fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants