fix(vue): restore placeholderData/initialData display fallback#827
Merged
Conversation
TanStack-compatible withDataFallback in makeQueryView: while pending with no cached value, surface placeholder/initial data (pre-select) without writing to the atom cache. Also document that agents must open PRs (draft while validating, ready when done).
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Failures without previousSuccess have no AsyncResult.value and were incorrectly replaced by placeholder/initialData. Gate the display fallback on isInitial so errors pass through unmasked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
placeholderData/initialDataas a display-level fallback in@effect-app/vuemakeQueryViewviawithDataFallback.datareturns the resolved placeholder (withselectapplied when set); neither option is written to the atom cache, so the real fetch still runs.AGENTS.md: always open PRs, draft while in progress/local validation, publish when ready.Test plan
pnpm --filter @effect-app/vue test queryOptions.test.ts(placeholder → real data, function form, select, initialData precedence)pnpm lint-fixpnpm checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.