Homework/01 basic - #43
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
WorkQueue<T>.TryDequeue uses ?? on Queue<T>.Dequeue(), which does not compile for value-type queues (e.g., WorkQueue<int> used by tests).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| } | ||
| Monitor.Wait(_items); | ||
| } | ||
| item = _items.Dequeue() ?? throw new InvalidOperationException("Queue is empty."); |
There was a problem hiding this comment.
🟡 Changes recommended
WorkQueue<T>.TryDequeue currently uses ?? on a generic T, which will not compile for value-type instantiations used by existing tests (e.g. WorkQueue<int>).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (2)
src/LocalCli/Program.cs:116
- Local variable names elsewhere in this file don’t use a leading underscore;
_logfileslooks like a private field and reduces readability. Rename it to a normal local name.
var _logfiles = analyzer.GetLogFiles();
foreach (var file in _logfiles)
docs/02-multithreading/report.md:126
- The referenced path
docs/02-multiheading/guidance.mdappears to be a typo; the actual directory isdocs/02-multithreading/.
- 第二次：我借助了AI完成CLI：提示词为"根据 `docs/02-multiheading/guidance.md` 中对于 T2.3 的要求，完成 `Program.cs`"
- Files reviewed: 8/10 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| } | ||
| Monitor.Wait(_items); | ||
| } | ||
| item = _items.Dequeue() ?? throw new InvalidOperationException("Queue is empty."); |
暑培：队式作业提交
基本信息
提交说明
01-basic作业提交通道 #32