fix: maxRows and maxCols typo#183
Open
okesseko wants to merge 2 commits into
Open
Conversation
neSpecc
reviewed
Sep 11, 2025
neSpecc
left a comment
neSpecc
left a comment
Contributor
There was a problem hiding this comment.
please, increment a patch version
Author
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the documentation, the configuration options are defined as
maxRowsandmaxCols,which should control the maximum number of rows and columns in the table.
Config Params
maxRowsnumber5by paramsmaxColsnumber5by paramsHowever, in the current source code these variables are defined as
maxrowsandmaxcols(all lowercase).As a result, the user-provided settings
maxRowsandmaxColsdo not work properly.This PR aligns the source code with the documented configuration by updating the variable names
to
maxRowsandmaxCols.