Improve eye tracking by jayvdb · Pull Request #99 · edge-toolkit/core

jayvdb · 2026-07-22T02:22:39Z

Summary by CodeRabbit

New Features
- Added webcam-based eye movement screening with iris tracking.
- Added analysis for eye misalignment and rhythmic oscillation.
- Added zoomed eye-region overlays, iris markers, and screening status indicators.
- The eye screening module is now selected by default when available.
Documentation
- Added a medical disclaimer explaining that results are heuristic signals, not medical advice.
Style
- Refined status cards, notes, typography, and layout styling.

coderabbitai · 2026-07-22T02:22:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebf62091-7d0c-4ddf-8edb-9236ece1eb81

📥 Commits

Reviewing files that changed from the base of the PR and between 30f92d3 and 0d59ade.

📒 Files selected for processing (11)

services/ws-modules/pyeye1/pkg/et_ws_pyeye1.js
services/ws-modules/pyeye1/pyeye1/__init__.py
services/ws-modules/pyeye1/pyeye1/eye_detection.py
services/ws-modules/pyeye1/pyeye1/gaze_analysis.py
services/ws-modules/pyeye1/pyproject.toml
services/ws-modules/pyeye1/tests/test_eye_detection.py
services/ws-modules/pyeye1/tests/test_gaze_analysis.py
services/ws-modules/pyeye1/tests/test_run_workflow.py
services/ws-server/static/app.js
services/ws-server/static/index.html
services/ws-server/static/style.css

📝 Walkthrough

Walkthrough

The PR replaces callback-driven eye detection with a Python-orchestrated eye movement screening workflow, adds iris and gaze analysis, updates browser rendering and payloads, and adjusts the web UI to select and describe the screening module.

Changes

Eye movement screening

Layer / File(s)	Summary
Gaze analysis contracts and heuristics `services/ws-modules/pyeye1/pyeye1/gaze_analysis.py`, `services/ws-modules/pyeye1/pyeye1/__init__.py`, `services/ws-modules/pyeye1/tests/test_gaze_analysis.py`	Adds gaze sample schemas and computes eyelid validity, eye misalignment, oscillation metrics, and combined window analysis with unit coverage.
Screening workflow and result payloads `services/ws-modules/pyeye1/pyeye1/eye_detection.py`, `services/ws-modules/pyeye1/tests/test_eye_detection.py`, `services/ws-modules/pyeye1/tests/test_run_workflow.py`, `services/ws-modules/pyeye1/pyproject.toml`	Reworks the asynchronous workflow around a platform interface, adds iris decoding and smoothed eye crops, includes analysis in status/event payloads, and tests success and cleanup failure paths.
Browser platform bridge and rendering `services/ws-modules/pyeye1/pkg/et_ws_pyeye1.js`	Moves browser operations behind a Python platform bridge and renders cropped eye regions, iris circles, and analysis overlays.
Module selection and screening presentation `services/ws-server/static/app.js`, `services/ws-server/static/index.html`, `services/ws-server/static/style.css`	Defaults module selection to `et-ws-pyeye1` when available and adds disclaimer, log-note, status markup, and corresponding styles.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant BrowserAdapter
  participant PythonWorkflow
  participant Camera
  participant FaceLandmarker
  participant WebSocketAgent
  participant Canvas
  BrowserAdapter->>PythonWorkflow: provide platformFor(state)
  PythonWorkflow->>WebSocketAgent: connect and send status
  PythonWorkflow->>Camera: acquire and start video
  PythonWorkflow->>FaceLandmarker: infer video frame
  PythonWorkflow->>WebSocketAgent: send analysis event
  PythonWorkflow->>BrowserAdapter: render result payload
  BrowserAdapter->>Canvas: draw crop, irises, and analysis overlay

Possibly related PRs

edge-toolkit/core#91: Modifies the same pyeye1 workflow and eye_detection.py APIs.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main theme of the changes: upgrading eye tracking to eye-movement screening and gaze analysis.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch eye-movement

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-07-22T02:22:58Z

DeepSource Code Review

We reviewed changes in 30f92d3...0d59ade on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene Coverage

Code Review Summary

Analyzer	Updated (UTC)	Details
C#	Jul 22, 2026 2:22a.m.	Review ↗
C & C++	Jul 22, 2026 2:22a.m.	Review ↗
Docker	Jul 22, 2026 2:22a.m.	Review ↗
Java	Jul 22, 2026 2:22a.m.	Review ↗
JavaScript	Jul 22, 2026 2:22a.m.	Review ↗
Python	Jul 22, 2026 2:22a.m.	Review ↗
Rust	Jul 22, 2026 2:22a.m.	Review ↗
Secrets	Jul 22, 2026 2:22a.m.	Review ↗
Code coverage	Jul 22, 2026 2:49a.m.	Review ↗

Code Coverage Summary

Language	Line Coverage (New Code)	Line Coverage (Overall)
Aggregate	92.4%	58.3% [▲ up 1.1% from `main`]
Python	92.4%	83% [▲ up 13.3% from `main`]
Rust	-	56.7%

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-07-22T02:23:15Z

+        for index, (dx, dy) in zip(RIGHT_IRIS_RING, ring_offsets, strict=True):
+            points[index] = (0.35 + dx, 0.50 + dy)
+        irises = decode_irises(landmarks_with(points), 1000.0, 500.0)
+        right = next(iris for iris in irises if iris["label"] == "right_eye")


Call to `next()` should be wrapped in `try-except`

Calls to next() should be inside try-except block.

deepsource-io · 2026-07-22T02:23:15Z

+    async def connect_ws(self) -> None:
+        pass
+
+    def ws_state(self) -> str:


Method doesn't use the class instance and could be converted into a static method

The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.

deepsource-io · 2026-07-22T02:23:15Z

+    def ws_state(self) -> str:
+        return "connected"
+
+    def agent_id(self) -> str:


Method doesn't use the class instance and could be converted into a static method

The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.

deepsource-io · 2026-07-22T02:23:15Z

+    async def start_camera(self) -> None:
+        pass
+
+    def video_size(self) -> list[int]:


Method doesn't use the class instance and could be converted into a static method

The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.

deepsource-io · 2026-07-22T02:23:19Z

-let cfg;
 let runtime = null;

 export default async function init() {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

Found non-compliant syntax. Confirm that there are no syntax errors before committing your code to a version control system.

codacy-production · 2026-07-22T02:23:46Z

Not up to standards ⛔

🔴 Issues 17 minor

Alerts:
⚠ 17 issues (≤ 0 issues of at least minor severity)

Results:
17 new issues

Category Results

Documentation 11 minor

CodeStyle 4 minor

Complexity 2 minor

View in Codacy

🟢 Metrics 164 complexity · 2 duplication

Metric Results

Complexity 164

Duplication 2

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

codecov · 2026-07-22T02:50:01Z

Codecov Report

❌ Patch coverage is 92.43028% with 19 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
services/ws-modules/pyeye1/pyeye1/eye_detection.py	86.86%	18 Missing ⚠️
services/ws-modules/pyeye1/pyeye1/gaze_analysis.py	99.11%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Improve eye tracking

0d59ade

deepsource-io Bot reviewed Jul 22, 2026

View reviewed changes

jayvdb marked this pull request as ready for review July 22, 2026 02:56

jayvdb requested a review from pierre-tenedero July 22, 2026 02:56

pierre-tenedero approved these changes Jul 22, 2026

View reviewed changes

jayvdb merged commit 8d69f15 into main Jul 22, 2026
30 of 34 checks passed

jayvdb deleted the eye-movement branch July 22, 2026 03:30

This was referenced Jul 22, 2026

Log images to server tty #100

Merged

Add pydemo1 #102

Merged

Update pydemo1 #104

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve eye tracking - #99

Improve eye tracking#99
jayvdb merged 1 commit into
mainfrom
eye-movement

jayvdb commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

deepsource-io Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot Jul 22, 2026

Uh oh!

deepsource-io Bot Jul 22, 2026

Uh oh!

deepsource-io Bot Jul 22, 2026

Uh oh!

deepsource-io Bot Jul 22, 2026

Uh oh!

deepsource-io Bot Jul 22, 2026

Uh oh!

codacy-production Bot commented Jul 22, 2026

Uh oh!

codecov Bot commented Jul 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jayvdb commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

deepsource-io Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Code Coverage Summary

Uh oh!

deepsource-io Bot Jul 22, 2026

Choose a reason for hiding this comment

Call to `next()` should be wrapped in `try-except`

Uh oh!

deepsource-io Bot Jul 22, 2026

Choose a reason for hiding this comment

Method doesn't use the class instance and could be converted into a static method

Uh oh!

deepsource-io Bot Jul 22, 2026

Choose a reason for hiding this comment

Method doesn't use the class instance and could be converted into a static method

Uh oh!

deepsource-io Bot Jul 22, 2026

Choose a reason for hiding this comment

Method doesn't use the class instance and could be converted into a static method

Uh oh!

deepsource-io Bot Jul 22, 2026

Choose a reason for hiding this comment

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

Uh oh!

codacy-production Bot commented Jul 22, 2026

Not up to standards ⛔

Uh oh!

codecov Bot commented Jul 22, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jayvdb commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

deepsource-io Bot commented Jul 22, 2026 •

edited

Loading