Rust bindings v1 by Choochmeque · Pull Request #284 · ecmwf/fdb

Choochmeque · 2026-06-03T11:20:55Z

Description

Use eckit high-level crate

Contributor Declaration

By opening this pull request, I affirm the following:

All authors agree to the Contributor License Agreement.
The code follows the project's coding standards.
I have performed self-review and added comments where needed.
I have added or updated tests to verify that my changes are effective and functional.
I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-284

…xample, because it should be reusable-action)

…is, and move_data

…ng keys

…ify API

… fdb-sys and fdb crates

… use

…ethods

…iability

…tionTest

tbkr

I looked at this PR and wonder in which state it is. Would it be possible to give me documentation/setup instructions for testing this local?

Also a rebase would be nice (although I appreciate that at the point in time when the PR was opened, this was up-to-date).

Have a look at the pinned versions (and the lack of them by pointing to develop) and update those, as well.

My overall comment would be: Which level of user-interaction are we targeting here? If this is on the C++ level we should keep the functions/objects as close as possible to the C++-API. If we are closer to the Python side, we should streamline things with the already existing PyFDB interface.

Happy to have a chat, if necessary.

tbkr · 2026-08-10T15:02:50Z

-eckit-sys = { git = "ssh://git@github.com/ecmwf/rust-wrappers-playground.git", default-features = false }
-metkit-sys = { git = "ssh://git@github.com/ecmwf/rust-wrappers-playground.git", default-features = false }
-eccodes-sys = { git = "ssh://git@github.com/ecmwf/rust-wrappers-playground.git", default-features = false }
+eckit-sys = { git = "ssh://git@github.com/ecmwf/eckit.git", branch = "develop", default-features = false }


We should probably introduce a reproducable build, which pins certain fixed versions. Depending on develop isn't the best idea.

tbkr · 2026-08-10T15:08:41Z

+    with:
+      manifest-path: rust/Cargo.toml
+      features: --features fdb-sys/vendored
+      run-doc: false


Docs should be build in the cicd, as well to see potential breakage.

Fixed in bba8cf5

tbkr · 2026-08-10T15:12:45Z

        .include(&eccodes_include)
        .include(crate_dir.join("cpp"))
+        .include(&out_dir) // for fdb_exceptions.h (generated)
        .flag_if_supported("-std=c++17")


use .std("c++17")

Fixed in 9d74e64

tbkr · 2026-08-10T15:14:20Z

        .include(format!("{eccodes_root}/include"))
        .include(crate_dir.join("cpp"))
+        .include(&out_dir) // for fdb_exceptions.h (generated)
        .flag_if_supported("-std=c++17")


again, .std

Fixed in 9d74e64

tbkr · 2026-08-10T15:18:50Z

-    /// Generic error from the FDB C++ library.
-    #[error("fdb error: {0}")]
-    Fdb(String),
+    /// Error from eckit/metkit C++ libraries.


Why did those disappear?

The old enum was a hand-maintained copy of eckit's exception hierarchy with String payloads. That now comes from eckit::Error, generated at build time from eckit/exception/Exceptions.h, so fdb wraps it as Error::Eckit instead of duplicating it - same variants, but they can't drift from the headers.

…rted("-std=c++17")`

…ings-v1

Choochmeque · 2026-08-19T11:56:12Z

Hi @tbkr,

Happy to have a chat, if necessary.

sure, let's discuss it in teams.

Choochmeque added 30 commits April 17, 2026 13:05

Initial commit

feadf80

C++ code formatting

d797611

Add GitHub Actions workflow for Rust project with checks and tests (e…

ec44a32

…xample, because it should be reusable-action)

Improve error handling in FFI callbacks to suppress panics

daa1adf

Update README with new FDB API usage examples and correct method calls

79eec1d

Refactor axes() to use dynamic mapping instead of hardcoded axis names

5c27e96

Add safety comments for thread-safety of various iterators in FDB

014c3de

Add integration tests for FDB methods: archive_raw, read_uri, read_ur…

6888dec

…is, and move_data

Fix CMake patching error handling and improve seek position calculations

5d43c67

Refactor FDB configuration accessors to return Option types for missi…

0886506

…ng keys

Add concurrent archive and mixed read/write tests for FDB operations

5f5b02b

Improve exception handling messages in fdb_bridge

4320482

Update rust CI workflow

0a4d9b0

Refactor FdbHandle to use direct FDB instance instead of unique_ptr

b9e0404

Remove unnecessary drop statements from FDB test cases

df834bc

Add support for user configuration in FdbHandle initialization and API

af8d471

Update iterator methods to return Result<bool> for hasNext checks

ae1d491

Add Cargo configuration and improve control identifier handling in FDB

baa976d

Update GRIB support and improve URI handling in FDB integration tests

cbcc8b7

Remove AxesIteratorHandle and related axes iterator functionality

990cb6e

Update log message for empty axes case to clarify request context

0fe11aa

Remove debug print statement for FDB name in example code

7d2bcc3

Update fdb_list example to format output as key-value pairs in braces

3a7672b

Remove FDB configuration methods and related data structures to simpl…

47ddce5

…ify API

Update documentation for HandleInner to clarify FDB instance usage

f03a576

Update README to correct FDB name and improve description clarity

826f9e1

Update README files to clarify feature flags and build strategies for…

57ef2ed

… fdb-sys and fdb crates

Update README and examples to clarify key requirements for FDB usage

117cf99

Add memfs feature to bake eccodes tables into libeccodes for easier…

a53a1c2

… use

Refactor version retrieval to use module-level functions instead of m…

1b1c6b5

…ethods

Choochmeque added 12 commits June 23, 2026 23:48

Split big file to dedicated modules

0d20cb1

Add reusable Rust CI workflow to main CI configuration

237f1a0

Add Library class for FDB metadata and initialization handling

dffcd91

Update documentation for MarsRequest to clarify DataHandle usage

fe7b678

Update MarsRequestBuilder example to use 'retrieve' instead of 'list'

dca3a98

Add initialization for eckit in the main function of FDB Hammer tool

1d2f5df

Update disable_subtocs argument to require a main config layer

dbf4296

Simplify archive and flush process in integration test for clarity

b897abc

Fix test to assert close() success in fdb_datareader_seek()

9a5da0b

Refactor tests to use tempdir-backed FDB config for isolation and rel…

7079283

…iability

Remove unused exception throwing methods and related tests from Excep…

eee476c

…tionTest

Cleanup

7076035

Choochmeque marked this pull request as ready for review June 23, 2026 23:52

Choochmeque and others added 5 commits August 6, 2026 13:51

Merge branch 'develop' into rust-bindings-v1

cdb5d26

Update dependencies and refactor MarsRequest usage

267bbba

Move cargo config.toml

0c933d8

Update metkit dependencies to use the develop branch

5d7a5ab

Merge branch 'develop' into rust-bindings-v1

08b456c

tbkr requested changes Aug 10, 2026

View reviewed changes

Choochmeque and others added 8 commits August 11, 2026 12:34

Merge branch 'develop' into rust-bindings-v1

85be293

Update build script to use .std("c++17") instead of `.flag_if_suppo…

9d74e64

…rted("-std=c++17")`

Merge branch 'develop' into rust-bindings-v1

2007dc1

Merge remote-tracking branch 'origin/develop' into rust-bindings-v1

815ff02

Merge remote-tracking branch 'origin/rust-bindings-v1' into rust-bind…

80afdcc

…ings-v1

Fix eccodes-sys dependency to resolve conflict with eckit-sys branch

3cfabd5

Merge branch 'develop' into rust-bindings-v1

9dc9bef

Merge branch 'develop' into rust-bindings-v1

7870818

Update CI workflow to include documentation generation for Rust project

bba8cf5

Choochmeque requested a review from tbkr August 26, 2026 16:42

Navigation Menu

Uh oh!

Rust bindings v1 - #284

Rust bindings v1#284
Choochmeque wants to merge 105 commits into
developfrom
rust-bindings-v1

Choochmeque commented Jun 3, 2026 •

edited by github-actions Bot

Loading

Uh oh!

tbkr left a comment

Uh oh!

tbkr Aug 10, 2026

Uh oh!

tbkr Aug 10, 2026

Uh oh!

Choochmeque Aug 25, 2026

Uh oh!

tbkr Aug 10, 2026

Uh oh!

Choochmeque Aug 25, 2026

Uh oh!

tbkr Aug 10, 2026

Uh oh!

Choochmeque Aug 25, 2026

Uh oh!

tbkr Aug 10, 2026

Uh oh!

Choochmeque Aug 25, 2026

Uh oh!

Choochmeque commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Choochmeque commented Jun 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Declaration

Uh oh!

tbkr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choochmeque commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Choochmeque commented Jun 3, 2026 •

edited by github-actions Bot

Loading