Repository navigation
Cancel pool connection timeout timer when acquisition fails - #1750
Merged
Merged
Conversation
…vertx#1712) * Cancel pool connection timeout timer when acquisition fails See eclipse-vertx#1706 When a pooled query fails to acquire a connection, the connection timeout timer is not cancelled, so it fails the query handler a second time when it fires. When the timer fires first, the acquisition failure also fails the handler again. Handle the acquisition failure like a successful acquisition: cancel the timer, and if it already fired, do not complete the handler again. Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com> * Use if/else in the acquisition failure branch Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com> --------- Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1712