fix: extract path parameters correctly when the router is mounted as … - #135
Merged
Conversation
…subrouter The position of a path parameter was calculated from the beginning of the OpenAPI path template and applied to the path of the incoming request. When the router built from the contract is mounted as a subrouter, the request path contains additional leading segments, so the calculated position pointed to the wrong segment and validation failed or, even worse, validated the wrong value. Since mounting a router can only prepend segments to the request path, the number of additional leading segments is now determined by comparing the number of segments of the request path with the number of segments of the path template, and the parameter position is shifted accordingly. For routers that are not mounted as subrouter the behaviour is unchanged. Fixes #120 (cherry picked from commit 2c61293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…subrouter
The position of a path parameter was calculated from the beginning of the OpenAPI path template and applied to the path of the incoming request. When the router built from the contract is mounted as a subrouter, the request path contains additional leading segments, so the calculated position pointed to the wrong segment and validation failed or, even worse, validated the wrong value.
Since mounting a router can only prepend segments to the request path, the number of additional leading segments is now determined by comparing the number of segments of the request path with the number of segments of the path template, and the parameter position is shifted accordingly. For routers that are not mounted as subrouter the behaviour is unchanged.
Fixes #120
(cherry picked from commit 2c61293)
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines