fix: accept whole numbers for the formats float and double - #133
Merged
Conversation
The formats float and double define the precision of a number, not its representation. Jackson parses JSON numbers without a decimal part into Integer or Long, so values like 10 were rejected with 'Number does not match the format' although they are valid numbers with float or double precision. Whole numbers are now accepted for the formats float and double, as long as they can be represented exactly with the related precision (2^24 for float, 2^53 for double). The behaviour for all other instance types is unchanged. Fixes #112 (cherry picked from commit a2e2dc1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formats float and double define the precision of a number, not its representation. Jackson parses JSON numbers without a decimal part into Integer or Long, so values like 10 were rejected with 'Number does not match the format' although they are valid numbers with float or double precision.
Whole numbers are now accepted for the formats float and double, as long as they can be represented exactly with the related precision (2^24 for float, 2^53 for double). The behaviour for all other instance types is unchanged.
Fixes #112
(cherry picked from commit a2e2dc1)
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines