Merged main into dev so dev carries the CLI host test fix - #77
Merged
Merged
Conversation
* Fix CORE-V CLI host test mocks * Added the licence header to the four new mock files The mocks arrived without one. Every other file in this directory carries the MIT header, and a source file entering an Eclipse project without a copyright line is the kind of omission that is cheap now and awkward later. The header is the plain MIT one rather than the AI disclosure variant the neighbouring mocks carry, because nothing here establishes how these were written and the disclosure is a statement about that. Build clean and the CLI host tests pass. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com> --------- Co-authored-by: Frédéric Desbiens <frederic.desbiens@eclipse-foundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64 was merged to
mainrather thandev, so the two branches diverged in both directions:mainhad that one commit anddevhad twenty without it.Nothing was at risk of being lost, since the eventual
devtomainmerge would have kept it. What it cost was the relationship between the branches: anyone starting fromdevworked without the CLI host test fix, andmainwas no longer simply trailingdev.This merges
mainintodevsodevis a superset again. It brings only #64; there is nothing else onmainthatdevlacks.Verified on the merged result: the CLI host tests build clean and all pass, and the licence headers added during review are present on all four mock files.