Skip to content

enable https for http things - #83

Merged
egekorkan merged 24 commits into
eclipse-thingweb:mainfrom
ki-do:feature/https
Oct 21, 2026
Merged

egekorkan merged 24 commits into
eclipse-thingweb:mainfrom
ki-do:feature/https

Conversation

@ki-do

@ki-do ki-do commented Jun 1, 2026

Copy link
Copy Markdown

make http thing advertise themselves as https

@egekorkan egekorkan linked an issue Jun 1, 2026 that may be closed by this pull request
Signed-off-by: Kirill Dorofeev <kirill.dorofeev@siemens.com>
@egekorkan egekorkan mentioned this pull request Jul 9, 2026
@ki-do

ki-do commented Jul 20, 2026

Copy link
Copy Markdown
Author

Additionally to introducing https, the last commits are fixing the following deployment issues:

  • MQTT/CoAP connections from mashup
  • Presence sensor broker configuration
  • Simple coffee machine URL construction bugs
  • Local vs. production deployment cleanup
  • Simple coffee machine: concurrent brewing prevention
  • Dockers' healthcheck command corrections
  • Enabled CORS for cross-origin requests

"nosec_sc"
],
"base": "http://localhost:3000/http-express-calculator-simple/",
"base": "https://localhost:3000/http-express-calculator-simple/",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be the plugfest domain?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the TD for calculator is created dynamically from the TM https://github.com/eclipse-thingweb/test-things/pull/83/changes#diff-f6fcf5e47c6fd46a0258bc05e9715aee29fd6ebf1bc8bbb25c9ef067c862db04L93 This TD is actually not used at all, as far as I can see from the code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TDs are actually only used for "documentation" purposes to statically provide them. Once the TDD integration happens automatically, we can simply link to the resources in the TDD.

"title": "Counter",
"description": "Counter example Thing",
"support": "https://github.com/eclipse-thingweb/node-wot/",
"base": "https://localhost:3000/counter/",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous but now I am guessing if we should put both the local TD and the publically available one on github

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docker-compose-things.yml
limits:
cpus: "0.05"
memory: 50M
memory: 256M

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question: Would it be better to NOT limit these and let docker automatically manage it?

Comment thread docker-compose-things.yml Resolved
@ki-do
ki-do force-pushed the feature/https branch 2 times, most recently from 31e1023 to b61bcf9 Compare August 5, 2026 09:17
…into feature/https

Signed-off-by: Kirill Dorofeev <dorofeev@fortiss.org>
Kirill Dorofeev and others added 3 commits August 11, 2026 10:10
Signed-off-by: Ege Korkan <egekorkan@gmail.com>
@ki-do
ki-do marked this pull request as draft October 8, 2026 21:11
@ki-do
ki-do force-pushed the feature/https branch 11 times, most recently from 5e55fc7 to b1a0789 Compare October 9, 2026 13:48
@ki-do
ki-do marked this pull request as ready for review October 12, 2026 14:25
@egekorkan

Copy link
Copy Markdown
Member

@danielpeintner @relu91 this PR is kind of ready kind of not, but it is an improvement already and all things except for two are working for a week in a stable state. Still to do are the following:

  • TDs of local (localhost and the local port) and public Things (plugfest.thingweb.io and the exposed port)
  • Publishing the new images on dockerhub and then changing the portainer setup
  • Fixing the unstability of http-express-calculator-content-negotiation and http-express-calculator
  • Also the MQTT and Modbus is not testable even as a client from the Siemens network. I need to test those at home later.

I will go ahead and will advertise these Things for the next week's plugfest

@egekorkan
egekorkan merged commit d6ccbff into eclipse-thingweb:main Oct 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use HTTPS

3 participants