[2303] Add support for list item inheritance in states and exhibit states compartments#2304
[2303] Add support for list item inheritance in states and exhibit states compartments#2304gcoutable wants to merge 1 commit into
Conversation
gcoutable
changed the base branch from
main
to
gco/enh/actions-compartment-inherited
gcoutable
force-pushed
the
gco/enh/states-compartment-inherited
branch
from
191b515 to
f003a8c
Compare
AxelRICHARD
force-pushed
the
gco/enh/actions-compartment-inherited
branch
from
3b0e8c3 to
1ac5e58
Compare
gcoutable
force-pushed
the
gco/enh/states-compartment-inherited
branch
2 times, most recently
from
30e4b43 to
bf7f83d
Compare
| * <li>Applies the tool {@code specializationToolName} to create a specialization relationship between the created node and the base element</li> | ||
| * </ol> | ||
| */ | ||
| private final class ElementSpecializationInheritanceChecker { |
There was a problem hiding this comment.
Please extract that in a separate file, probably in backend/views/syson-diagram-tests/src/main/java/org/eclipse/syson/diagram/tests/checkers
There was a problem hiding this comment.
This class doesn't actually function as a checker as intended by AbstractChecker.
Instead, it serves as a way to parameterize a test, and thus, it has no purpose outside this test class.
I propose to rename the inner class to ElementSpecializationInheritanceTestRunner but I would like to keep it inside because it is intertwined with the test class, like all autowired attributes, the editing context, ...
| } | ||
|
|
||
| @Override | ||
| public Boolean caseExhibitStateUsage(ExhibitStateUsage object) { |
There was a problem hiding this comment.
please add this case just after caseConstraintUsage to respect the alphabetical order
There was a problem hiding this comment.
I also moved caseFeature and defaultCase
| */ | ||
| public class InheritedCompartmentItemFilterSwitch extends SysmlSwitch<Boolean> { | ||
|
|
||
| private final Type type; |
There was a problem hiding this comment.
please explain what is this class attribute
There was a problem hiding this comment.
Indeed, there is no need for that class attribute
…ates compartments Bug: #2303 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable
force-pushed
the
gco/enh/states-compartment-inherited
branch
from
bf7f83d to
eb7962a
Compare
2 participants
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests