fix: escalate ProcessInfoNode construction failures - #616
Open
shegazyy wants to merge 1 commit into
Open
Conversation
Previously, if alive supervision construction failed inside ProcessInfoNode's constructor, the failure was logged and startup continued anyway with a null supervision handle. Convert ProcessInfoNode's constructor to a Create() factory that returns an error (kErrorBeforeReady) if alive supervision setup fails. Propagate that failure through Graph::Create() (also converted from a plain constructor to a factory, since building the dependency graph can now fail) up to ProcessGroupManager::initializeProcessGroups(), which already fails startup on false. Also fixes a latent bug found while adding this: ProcessInfoNode's move constructor did not preserve start_tries_ or termination_result_, silently resetting configured restart attempts to 1 on every move. This was previously undetectable because the move constructor was never exercised on ordinary construction; Create() now moves through it at least once.
shegazyy
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 8, 2026 16:24
shegazyy
requested a deployment
to
workflow-approval
September 8, 2026 16:24 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 8, 2026 16:24 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
Author
|
Hello @WilliamRoebuck I applied the needed changes and ready for review whenever you have the time> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if alive supervision construction failed inside ProcessInfoNode's constructor, the failure was logged and startup continued anyway with a null supervision handle.
Convert ProcessInfoNode's constructor to a Create() factory that returns an error (kErrorBeforeReady) if alive supervision setup fails. Propagate that failure through Graph::Create() (also converted from a plain constructor to a factory, since building the dependency graph can now fail) up to ProcessGroupManager::initializeProcessGroups(), which already fails startup on false.
Also fixes a latent bug found while adding this: ProcessInfoNode's move constructor did not preserve start_tries_ or termination_result_, silently resetting configured restart attempts to 1 on every move. This was previously undetectable because the move constructor was never exercised on ordinary construction; Create() now moves through it at least once.
Fixes #606