Proposal to manage visibility of subcomponents - #612
Draft
NicolasFussberger wants to merge 3 commits into
Draft
Conversation
NicolasFussberger
requested a deployment
to
workflow-approval
September 8, 2026 06:20 — with
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
September 8, 2026 06:20 — with
GitHub Actions
Waiting
NicolasFussberger
force-pushed
the
tighten_alivemonitor_visibility
branch
from
September 8, 2026 06:21
404c800 to
97848b7
Compare
NicolasFussberger
deployed
to
workflow-approval
September 8, 2026 06:21 — with
GitHub Actions
Active
NicolasFussberger
deployed
to
workflow-approval
September 8, 2026 06:21 — with
GitHub Actions
Active
NicolasFussberger
changed the base branch from
main
to
reenable_qnx_integration_tests
September 11, 2026 05:58
NicolasFussberger
force-pushed
the
tighten_alivemonitor_visibility
branch
from
September 11, 2026 06:01
97848b7 to
cf25d86
Compare
NicolasFussberger
deployed
to
workflow-approval
September 11, 2026 06:01 — with
GitHub Actions
Active
NicolasFussberger
deployed
to
workflow-approval
September 11, 2026 06:01 — with
GitHub Actions
Active
NicolasFussberger
force-pushed
the
tighten_alivemonitor_visibility
branch
from
September 11, 2026 06:13
cf25d86 to
11820d1
Compare
NicolasFussberger
requested a deployment
to
workflow-approval
September 11, 2026 06:13 — with
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
September 11, 2026 06:13 — with
GitHub Actions
Waiting
NicolasFussberger
changed the base branch from
reenable_qnx_integration_tests
to
main
September 11, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The folder structure already highlights the intended visibility.
For example:
To make this more explicit and to enforce it via bazel, this PR proposes to define two package groups in the top-level build file of the component:
The targets in score/launch_manager/src/daemon/src/alive_monitor/BUILD will get by default the visibility from "api" while the targets in score/launch_manager/src/daemon/src/alive_monitor/details will by default get visibility "internal".
The same pattern could be repeated for all (sub)components